Hi Fabio, > Hi Lukasz, > > On Thu, Jan 11, 2024 at 8:06 AM Lukasz Majewski <lu...@denx.de> wrote: > > > +serverip=10.8.217.79 > > +nfs_serverip=10.8.218.113 > > +gatewayip=10.8.209.250 > > These IP addresses should not be hardcoded here. > > They were not present in xea.h originally. Please remove them.
Those are the IP's for customer's production setup. In that way I could just point to mainline SHA1 and just use the sources without any further adjustments. I can agree, that on "common devel board" (like e.g. beaglebone) it would be problematic to have it hardcoded, but as this one is customer specific HW ... Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lu...@denx.de
pgpzWpSNKl7oN.pgp
Description: OpenPGP digital signature
