On Sat, 6 Jan 2024 23:21:34 +0100 Philippe Coval <[email protected]> wrote:
(CC:ing Olliver, can you confirm that this quirk applies to the Micro too?) Hi Philippe, thanks for taking care of upstreaming this! > This change fix reboot, it was tested on debian-12 So I am wondering why this only comes up now. Was that always broken, and nobody cared (or ran mainline U-Boot)? Or does the problem only show under certain circumstances? It would be good if you can elaborate about that in the commit message, to show *why* your patch is needed. > It was inspired from for-master-20181206-10-g8311e84b18 Referencing a commit here looks odd. You could just mention that this quirk is also used on the Lime2 boards. > Relate-to: https://github.com/rzr/u-boot/issues/2 > Thanks-to: Olliver Schinagl <[email protected]> Please don't invent tags. If you want to give credit for things like advice or support, mention their name in the commit message, and maybe add them in CC: If you have a *stable* link with useful(!) information, use the Link: tag. > Signed-off-by: Philippe Coval <[email protected]> > --- > > configs/A20-OLinuXino_MICRO_defconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/configs/A20-OLinuXino_MICRO_defconfig > b/configs/A20-OLinuXino_MICRO_defconfig If you change this file, that probably means that the eMMC version is also affected? Same as the two Lime2 boards, where we set the symbol in *both* defconfigs? So can you please add that symbol there as well? Cheers, Andre > index db4270f9b2..673ab85c8a 100644 > --- a/configs/A20-OLinuXino_MICRO_defconfig > +++ b/configs/A20-OLinuXino_MICRO_defconfig > @@ -20,6 +20,7 @@ CONFIG_ETH_DESIGNWARE=y > CONFIG_MII=y > CONFIG_SUN7I_GMAC=y > CONFIG_SUN7I_GMAC_FORCE_TXERR=y > +CONFIG_AXP_ALDO3_INRUSH_QUIRK=y > CONFIG_AXP_ALDO3_VOLT=2800 > CONFIG_AXP_ALDO4_VOLT=2800 > CONFIG_SCSI=y
