Dear Luca Ceresoli, In message <[email protected]> you wrote: > Signed-off-by: Luca Ceresoli <[email protected]> > Cc: Wolfgang Denk <[email protected]> > Cc: Albert Aribaud <[email protected]> > Cc: Sandeep Paulraj <[email protected]> > --- > Changes in v2: > - this patch is new in v2. > > Changes in v3: none. > > arch/arm/cpu/armv7/omap3/mem.c | 2 +- > include/configs/am3517_evm.h | 2 +- > include/configs/omap3_evm.h | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/arm/cpu/armv7/omap3/mem.c b/arch/arm/cpu/armv7/omap3/mem.c > index bd914b0..e9de05d 100644 > --- a/arch/arm/cpu/armv7/omap3/mem.c > +++ b/arch/arm/cpu/armv7/omap3/mem.c > @@ -39,7 +39,7 @@ unsigned int boot_flash_base; > unsigned int boot_flash_off; > unsigned int boot_flash_sec; > unsigned int boot_flash_type; > -volatile unsigned int boot_flash_env_addr; > +unsigned int boot_flash_env_addr; > > struct gpmc *gpmc_cfg; > > diff --git a/include/configs/am3517_evm.h b/include/configs/am3517_evm.h > index 70e8f07..bc2e8bb 100644 > --- a/include/configs/am3517_evm.h > +++ b/include/configs/am3517_evm.h > @@ -325,7 +325,7 @@ > > #ifndef __ASSEMBLY__ > extern unsigned int boot_flash_base; > -extern volatile unsigned int boot_flash_env_addr; > +extern unsigned int boot_flash_env_addr; > extern unsigned int boot_flash_off; > extern unsigned int boot_flash_sec; > extern unsigned int boot_flash_type; > diff --git a/include/configs/omap3_evm.h b/include/configs/omap3_evm.h > index 5bdb3fd..570e794 100644 > --- a/include/configs/omap3_evm.h > +++ b/include/configs/omap3_evm.h > @@ -320,7 +320,7 @@ > > #ifndef __ASSEMBLY__ > extern unsigned int boot_flash_base; > -extern volatile unsigned int boot_flash_env_addr; > +extern unsigned int boot_flash_env_addr; > extern unsigned int boot_flash_off; > extern unsigned int boot_flash_sec; > extern unsigned int boot_flash_type;
Can we please get rid off all these extern declarations in board config files? It is a maintenance nightmare that we have to repeat allt hese stuff in several board config files - this is a clear indication of a design problem, that needs to be fixed. Can we please move this stuff to some common place instead? Thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [email protected] If all you have is a hammer, everything looks like a nail. _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
