Hi Wolfgang,

Thanks for your inputs...

The first two points are the features provided by the same code change. They 
should be in the same patch.


Adding of USB2 controller offset is for supporting second USB controller in 
QoriQ series of processors.

I can send a separate patch for that.

So I'll break this patch into two ... one with "adding support for USB mode and 
phy type device-tree fix-up, where mode and phy type are fetched via hwconfig 
string"

And other for "adding second USB controller offset for QorIQ series of 
processors"

Please tell if this would be fine ...

Thanks and Regards,
Ramneek


 

-----Original Message-----
From: Wolfgang Denk [mailto:w...@denx.de] 
Sent: Wednesday, April 06, 2011 10:47 AM
To: Mehresh Ramneek-B31383
Cc: u-boot@lists.denx.de
Subject: Re: [U-Boot] [PATCH] powerpc/qoriq: Update USB mode device tree fixup

Dear Ramneek Mehresh,

In message <1300789256-14487-1-git-send-email-ramneek.mehr...@freescale.com> 
you wrote:
> Modify support for USB mode fixup:
>       - Add support for fetching USB mode and phy type
>         via hwconfig
>       - Add common support for USB mode and phy type
>         device tree fix-up for all USB controllers
>         mentioned in hwconfig string
>       - Add USB2 controller offset

Sounds as if these were 3 independent changes, so these should go into three 
separate patches.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de The 
goal of science is to build better mousetraps. The goal of nature is to build 
better mice.


_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to