On Wed, 28 Feb 2024 at 22:07, Tim Harvey <[email protected]> wrote: > > On Tue, Feb 27, 2024 at 3:19 PM Adam Ford <[email protected]> wrote: > > > > On Mon, Feb 26, 2024 at 2:05 AM Sumit Garg <[email protected]> wrote: > > > > > > pcie_imx doesn't seem to share any useful code for iMX8 SoC and it is > > > tied to quite old port of pcie_designware driver from Linux which > > > suffices only iMX6 specific needs. > > > > > > But currently we have the common DWC specific bits which alligns pretty > > > well with DW PCIe controller on iMX8MP SoC. So lets reuse those common > > > bits instead as a new driver for iMX8 SoCs. It should be fairly easy to > > > add support for other iMX8 variants to this driver. > > > > > > iMX8MP SoC also comes up with standalone PCIe PHY support, so hence we > > > can reuse the generic PHY infrastructure to power on PCIe PHY. > > > > > > Signed-off-by: Sumit Garg <[email protected]> > > > --- > > > drivers/pci/Kconfig | 8 + > > > drivers/pci/Makefile | 1 + > > > drivers/pci/pcie_dw_imx.c | 314 ++++++++++++++++++++++++++++++++++++++ > > > 3 files changed, 323 insertions(+) > > > create mode 100644 drivers/pci/pcie_dw_imx.c > > > > > > diff --git a/drivers/pci/Kconfig b/drivers/pci/Kconfig > > > index 463ec47eb92d..7edbf35004a9 100644 > > > --- a/drivers/pci/Kconfig > > > +++ b/drivers/pci/Kconfig > > > @@ -413,4 +413,12 @@ config PCIE_STARFIVE_JH7110 > > > Say Y here if you want to enable PLDA XpressRich PCIe controller > > > support on StarFive JH7110 SoC. > > > > > > +config PCIE_DW_IMX > > > + bool "i.MX DW PCIe controller support" > > > + depends on ARCH_IMX8M > > > > I think this also needs to depend on REGMAP to prevent build errors. > > > > Sumit, > > both REGMAP and SYSCON are needed to build. >
Ack. -Sumit
