Hi Kever,
On 2024-03-11 10:29, Kever Yang wrote:
> Hi Jonas,
>
> On 2024/2/18 02:35, Jonas Karlman wrote:
>> Move ROCK Pi 4 specific board code from the shared evb_rk3399 target
>> into its own board target and update related defconfigs to use the new
>> TARGET_ROCKPI4_RK3399 option.
>>
>> Also move the call to gpt_capsule_update_setup() from the weak function
>> rk_board_late_init() into the main board_late_init() function.
>
> Please split this part as a separate patch, this is an common code
> update instead of rockpi board patch.
Will split this into its own patch in v2.
>
>
>>
>> Signed-off-by: Jonas Karlman <jo...@kwiboo.se>
>> ---
>> arch/arm/mach-rockchip/board.c | 10 +++---
>> arch/arm/mach-rockchip/rk3399/Kconfig | 6 ++++
>> board/radxa/rockpi4-rk3399/Kconfig | 15 +++++++++
>> board/radxa/rockpi4-rk3399/MAINTAINERS | 29 +++++++++++++++++
>> .../rockpi4-rk3399}/Makefile | 2 +-
>> .../rockpi4-rk3399/rockpi4-rk3399.c} | 13 ++------
>> board/rockchip/evb_rk3399/MAINTAINERS | 29 -----------------
>> configs/rock-4c-plus-rk3399_defconfig | 2 +-
>> configs/rock-4se-rk3399_defconfig | 2 +-
>> configs/rock-pi-4-rk3399_defconfig | 2 +-
>> configs/rock-pi-4c-rk3399_defconfig | 2 +-
>> include/configs/rk3399_common.h | 16 ----------
>> include/configs/rockpi4-rk3399.h | 32 +++++++++++++++++++
>> 13 files changed, 95 insertions(+), 65 deletions(-)
>> create mode 100644 board/radxa/rockpi4-rk3399/Kconfig
>> create mode 100644 board/radxa/rockpi4-rk3399/MAINTAINERS
>> rename board/{rockchip/evb_rk3399 => radxa/rockpi4-rk3399}/Makefile (79%)
>> rename board/{rockchip/evb_rk3399/evb-rk3399.c =>
>> radxa/rockpi4-rk3399/rockpi4-rk3399.c} (79%)
>
> Please add new rockpi4 board files instead of rename, so that evb-rk3399
> can still available.
This only looks like a rename because the only code that was left in
evb-rk3399.c was the rock-pi-4 specific capsule update code moved to
the new rockpi4-rk3399.c file.
board/rockchip/evb_rk3399 still exists and contain the Kconfig, README
and MAINTAINERS files after this patch, just no board specific code.
So will keep this change as-is for v2.
Regards,
Jonas
>
>
> Thanks,
> - Kever
>> create mode 100644 include/configs/rockpi4-rk3399.h
>>
[snip]
