On Wed, Mar 27, 2024 at 8:53 PM Peng Fan (OSS) <peng....@oss.nxp.com> wrote:

> +&lpi2c2 {
> +       #address-cells = <1>;
> +       #size-cells = <0>;
> +       clock-frequency = <400000>;
> +       pinctrl-names = "default", "sleep";
> +       pinctrl-0 = <&pinctrl_lpi2c2>;
> +       pinctrl-1 = <&pinctrl_lpi2c2>;
> +       status = "okay";
> +
> +       pmic@25 {
....
> +       adp5585gpio: gpio@34 {
> +               compatible = "adp5585";
> +               reg = <0x34>;
> +               gpio-controller;
> +               #gpio-cells = <2>;

Please add a comment saying these nodes are already available in 6.9-rc1.

> --- a/arch/arm/mach-imx/imx9/Kconfig
> +++ b/arch/arm/mach-imx/imx9/Kconfig
> @@ -31,6 +31,7 @@ choice
>  config TARGET_IMX93_11X11_EVK
>         bool "imx93_11x11_evk"
>         select IMX93
> +       imply OF_UPSTREAM

Sumit and I asked you to add OF_UPSTREAM to all imx93 boards, not just this one.

Please don't ignore review comments.

Reply via email to