Dear Macpaul Lin, In message <[email protected]> you wrote: > Faraday's ftide020_s is an IDE-AHB controller for SoC design. > This patch ported the u-boot driver (PIO) of ftide020 ATA (IDE) driver > from Linux kernel. IDE commands include read, info, and other functions > has been implemented.
When copying code from Linux, you must give exact reference from which file and which exact version (commit ID) the code was taken rom; please see bullet # 4 at http://www.denx.de/wiki/view/U-Boot/Patches#Attributing_Code_Copyrights_Sign ... > +extern ulong ide_bus_offset[CONFIG_SYS_IDE_MAXBUS]; See before - please move to header file. ... > + tcyc = (u8) (((UDMA_ACCESS_TIMING[UDMA_TCYC][mode] * > sysclk) + 9990) / 10000); > + tcvs = (u8) (((UDMA_ACCESS_TIMING[UDMA_TCVS][mode] * > sysclk) + 9990) / 10000); > + tmli = (u8) (((UDMA_ACCESS_TIMING[UDMA_TMLI][mode] * > sysclk) + 9990) / 10000); > + tenv = (u8) (((UDMA_ACCESS_TIMING[UDMA_TENV][mode] * > sysclk) + 9990) / 10000); > + trp = (u8) (((UDMA_ACCESS_TIMING[UDMA_TRP][mode] * > sysclk) + 9990) / 10000); > + tack = (u8) (((UDMA_ACCESS_TIMING[UDMA_TACK][mode] * > sysclk) + 9990) / 10000); Lines too long, please fix globally. ... > +/* set device: (CF4) */ > +#define IDE_SET_OPCODE (0x2740 << 2) /* [15:2], > 0x9d00 */ please, no space before tabs. Please fix globally. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [email protected] When all is said and done, more is said than done. _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
