On Thu, Mar 28, 2024 at 05:29:50PM -0500, Sam Protsenko wrote:
> In part_get_info_by_name() the inability to get some partition info
> shouldn't be a reason for dropping out of the loop. That might happen
> e.g. if the partition is hidden or unused. An example of such case are
> Samsung devices, where they use the "unused" GUID type
> (00000000-0000-0000-0000-000000000000) to indicate that the partition
> should be hidden from the OS. Such partitions might not be seen in
> "part list" output, which creates "gaps" in numbering in between of the
> visible partitions:
>
> Part Start LBA End LBA Name
> 1 0x00000400 0x0000a3ff "efs"
> 5 0x00026420 0x00026c1f "dtbo"
> 12 0x0003f390 0x0074738f "super"
>
> In that case, the loop in part_get_info_by_name() would break after
> partition #1, so any attempt to obtain "dtbo" or "super" partition will
> fail. Fix that by continuing to iterate over the remaining partitions to
> make sure none of the visible ones is missed. That makes "part" command
> (e.g. "part start", "part size") able to work with such tables.
>
> Fixes: 87b8530fe244 ("disk: part: implement generic function
> part_get_info_by_name()")
> Signed-off-by: Sam Protsenko <[email protected]>
> Reviewed-by: Heinrich Schuchardt <[email protected]>Applied to u-boot/master, thanks! -- Tom
signature.asc
Description: PGP signature
