On Tue Jan 23, 2024 at 6:16 PM CET, Svyatoslav Ryhel wrote: > From: Jonas Schwöbel <[email protected]> > > Framebuffer address should not be a pointer. > > Signed-off-by: Jonas Schwöbel <[email protected]> > Signed-off-by: Svyatoslav Ryhel <[email protected]> > --- > drivers/video/tegra20/tegra-dc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/video/tegra20/tegra-dc.c > b/drivers/video/tegra20/tegra-dc.c > index a8e32e6893..000a0e02f8 100644 > --- a/drivers/video/tegra20/tegra-dc.c > +++ b/drivers/video/tegra20/tegra-dc.c > @@ -429,7 +429,7 @@ static int tegra_lcd_probe(struct udevice *dev) > uc_priv->xsize = priv->width; > uc_priv->ysize = priv->height; > uc_priv->bpix = priv->log2_bpp; > - debug("LCD frame buffer at %pa, size %x\n", &priv->frame_buffer, > + debug("LCD frame buffer at %08x, size %x\n", priv->frame_buffer,
%pa is usually treated in a special way. At least it is on Linux, not sure if the U-Boot printf implementation uses this, too. Looking at doc/develop/printf.rst, it seems like this is supported, and given that priv->frame_buffer is fdt_addr_t, %pa seems totally appropriate here. Thierry
signature.asc
Description: PGP signature
