Hi Jonas,

On 4/22/24 19:54, Jonas Karlman wrote:
Hi Quentin,

On 2024-04-22 18:41, Quentin Schulz wrote:
From: Quentin Schulz <quentin.sch...@theobroma-systems.com>
[...]
diff --git a/arch/arm/dts/rk3588-tiger-haikou-u-boot.dtsi 
b/arch/arm/dts/rk3588-tiger-haikou-u-boot.dtsi
new file mode 100644
index 00000000000..4259399193a
--- /dev/null
+++ b/arch/arm/dts/rk3588-tiger-haikou-u-boot.dtsi
[...]

Following should be added to possible fix uart2 pinctrl in SPL:

   &uart2m2_xfer {
        bootph-all;
   };


Would only be useful once we get rid of DDR bin, but will do it now because I have a feeling I would forget otherwise :)

Thanks for catching this though.

[...]

[snip]

diff --git a/configs/tiger-rk3588_defconfig b/configs/tiger-rk3588_defconfig
new file mode 100644
index 00000000000..6545445bba1
--- /dev/null
+++ b/configs/tiger-rk3588_defconfig
[...]
+CONFIG_USB_XHCI_DWC3=y

Please use USB_DWC3_GENERIC instead of USB_XHCI_DWC3.


Dang, I thought I was using "the correct one".

It's very difficult to know which one to pick right now, would it be possible to update the help message to guide the users a bit more in their choice? I don't really have a clue why one is "better" than the other so wouldn't be able to suggest something.

Cheers,
Quentin

Reply via email to