Hi Simon, > -----Original Message----- > From: Simon Glass <[email protected]> > Sent: Tuesday, June 4, 2024 9:14 PM > To: Maier, Brandon L Collins <[email protected]> > Cc: [email protected] > Subject: [External] Re: [PATCH 2/3] tools: binman: fix deprecated Python > ConfigParser methods > > Hi Brandon, > > On Tue, 4 Jun 2024 at 10:16, Brandon Maier <[email protected]> > wrote: > > > > The method `ConfigParser.readfp()` is marked deprecated[1]. > > > > In Python 3.12 this method have been removed, so replace it with > > `ConfigParser.read_file()`. > > > > [1] > https://docs.python.org/3.11/library/configparser.html#configparser.ConfigParser.read_file > > Signed-off-by: Brandon Maier <[email protected]> > > CC: Simon Glass <[email protected]> > > --- > > tools/buildman/bsettings.py | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > Reviewed-by: Simon Glass <[email protected]> > > Does this still work in earlier Pythons?
The Python docs say ConfigParser.read_file() was added in Python 3.2. The tools/buildman/pyproject.toml says `requires-python = ">=3.7"` so I assume this is fine. > > Regards, > Simon

