Hi Marek, Thank you for the patch.
On dim., juin 09, 2024 at 23:32, Marek Vasut <[email protected]> wrote: > The bcdDevice field is defined as > |Device release number in binary-coded decimal > in the USB 2.0 specification. We use this field to distinguish the UDCs > from each other. In theory this could be used on the host side to apply > certain quirks if the "special" UDC in combination with this gadget is > used. This hasn't been done as far as I am aware. In practice it would > be better to fix the UDC driver before shipping since a later release > might not need this quirk anymore. > > This patch removes the newly unused function. Linux stopped using this > functionality in 2012, remove it from U-Boot as well. > > Matching Linux kernel commit: > ed9cbda63d45 ("usb: gadget: remove usb_gadget_controller_number()") > > Signed-off-by: Marek Vasut <[email protected]> Reviewed-by: Mattijs Korpershoek <[email protected]> Tested-by: Mattijs Korpershoek <[email protected]> # on vim3 > --- > Cc: Alexander Sverdlin <[email protected]> > Cc: Felipe Balbi <[email protected]> > Cc: Lukasz Majewski <[email protected]> > Cc: Mattijs Korpershoek <[email protected]> > Cc: Nishanth Menon <[email protected]> > Cc: Simon Glass <[email protected]> > Cc: Thinh Nguyen <[email protected]> > Cc: Tom Rini <[email protected]> > Cc: [email protected] > --- > drivers/usb/gadget/gadget_chips.h | 62 ------------------------------- > 1 file changed, 62 deletions(-) > > diff --git a/drivers/usb/gadget/gadget_chips.h > b/drivers/usb/gadget/gadget_chips.h > index 98156c312d2..316051686c4 100644 > --- a/drivers/usb/gadget/gadget_chips.h > +++ b/drivers/usb/gadget/gadget_chips.h > @@ -146,65 +146,3 @@ > #else > #define gadget_is_dwc2(g) 0 > #endif > - > -/** > - * usb_gadget_controller_number - support bcdDevice id convention > - * @gadget: the controller being driven > - * > - * Return a 2-digit BCD value associated with the peripheral controller, > - * suitable for use as part of a bcdDevice value, or a negative error code. > - * > - * NOTE: this convention is purely optional, and has no meaning in terms of > - * any USB specification. If you want to use a different convention in your > - * gadget driver firmware -- maybe a more formal revision ID -- feel free. > - * > - * Hosts see these bcdDevice numbers, and are allowed (but not encouraged!) > - * to change their behavior accordingly. For example it might help avoiding > - * some chip bug. > - */ > -static inline int usb_gadget_controller_number(struct usb_gadget *gadget) > -{ > - if (gadget_is_net2280(gadget)) > - return 0x01; > - else if (gadget_is_dummy(gadget)) > - return 0x02; > - else if (gadget_is_sh(gadget)) > - return 0x04; > - else if (gadget_is_goku(gadget)) > - return 0x06; > - else if (gadget_is_mq11xx(gadget)) > - return 0x07; > - else if (gadget_is_omap(gadget)) > - return 0x08; > - else if (gadget_is_n9604(gadget)) > - return 0x09; > - else if (gadget_is_at91(gadget)) > - return 0x12; > - else if (gadget_is_imx(gadget)) > - return 0x13; > - else if (gadget_is_musbhsfc(gadget)) > - return 0x14; > - else if (gadget_is_musbhdrc(gadget)) > - return 0x15; > - else if (gadget_is_atmel_usba(gadget)) > - return 0x17; > - else if (gadget_is_fsl_usb2(gadget)) > - return 0x18; > - else if (gadget_is_amd5536udc(gadget)) > - return 0x19; > - else if (gadget_is_m66592(gadget)) > - return 0x20; > - else if (gadget_is_ci(gadget)) > - return 0x21; > - else if (gadget_is_dwc3(gadget)) > - return 0x23; > - else if (gadget_is_cdns3(gadget)) > - return 0x24; > - else if (gadget_is_max3420(gadget)) > - return 0x25; > - else if (gadget_is_mtu3(gadget)) > - return 0x26; > - else if (gadget_is_dwc2(gadget)) > - return 0x27; > - return -ENOENT; > -} > -- > 2.43.0
