Hi Heinrich, On Thu, 20 Jun 2024 at 18:23, Heinrich Schuchardt <[email protected]> wrote: > > On 18.06.24 17:49, Ilias Apalodimas wrote: > > EFI_IGNORE_OSINDICATIONS is used to ignore OsIndications if setvariable > > at runtime is not supported and allow the platform to perform capsule > > updates on disk. With the recent changes boards can conditionally enable > > setvariable at runtime using EFI_RT_VOLATILE_STORE. > > > > So let's make the options depend on each other and clarify their > > functionality. When EFI_RT_VOLATILE_STORE, setvariable at runtime is > > supported and EFI_IGNORE_OSINDICATIONS, which also breaks the EFI spec, is > > not needed anymore. > > > > Signed-off-by: Ilias Apalodimas <[email protected]> > > --- > > lib/efi_loader/Kconfig | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/lib/efi_loader/Kconfig b/lib/efi_loader/Kconfig > > index 430bb7f0f7dc..c84064de1366 100644 > > --- a/lib/efi_loader/Kconfig > > +++ b/lib/efi_loader/Kconfig > > @@ -220,6 +220,8 @@ config EFI_CAPSULE_ON_DISK > > config EFI_IGNORE_OSINDICATIONS > > bool "Ignore OsIndications for CapsuleUpdate on-disk" > > depends on EFI_CAPSULE_ON_DISK > > + depends on !EFI_RT_VOLATILE_STORE > > EFI_RT_VOLATILE_STORE does not imply that the OS that you are running > supports writing variables to ubootefi.var or eMMC. > > How about > > default y if !EFI_RT_VOLATILE_STORE
Sure, that works for me. I'll send a v2 Cheers > > Best regards > > Heinrich > > > + default y > > help > > There are boards where U-Boot does not support SetVariable at > > runtime. > > Select this option if you want to use the capsule-on-disk feature >
