> -----Original Message----- > From: Wolfgang Denk [mailto:[email protected]] > Sent: Monday, April 25, 2011 7:17 AM > To: Zang Roy-R61911 > Cc: [email protected]; Wood Scott-B07421; Kumar Gala > Subject: Re: [PATCH] powerpc:Enable compiler debug option for powerpc > platforms > > Dear Roy Zang, > > In message <[email protected]> you > wrote: > > This patch enables compiler debug option for powerpc platforms > > by default. Patch is tested on 85xx/QorIQ platforms in u-boot > > with CodeWarrior. > > > > Signed-off-by: Roy Zang <[email protected]> > > Cc: Wood Scott-B07421 <[email protected]> > > Cc: Kumar Gala <[email protected]> > > --- > > Consider the comments > > http://lists.denx.de/pipermail/u-boot/2010-October/080689.html > > http://lists.denx.de/pipermail/u-boot/2011-January/086485.html > > Indeed. In > http://lists.denx.de/pipermail/u-boot/2011-January/086485.html > I wrote: > > | I don't see where this is specific to the Power architecture either - > | expect that you only tested it there. > | > | My understanding is that you enable debug settings for the GNU > | debugger. > | > | Do these need to be architecture specific? Probably not. > | > | Do these need to be enabled by a new #define? What would be the > | disadvantages of having these options always enabled, for all > | architectures? > > You did not comment to these questions, and your current code is > still powerpc-centric. Yes. because there is other voice: http://lists.denx.de/pipermail/u-boot/2011-January/086489.html http://lists.denx.de/pipermail/u-boot/2011-January/086512.html any comment? Roy
_______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
