Hi Simon On Tue, 6 Aug 2024 at 15:59, Simon Glass <s...@chromium.org> wrote: > > This tests maps some local variables into sandbox's address space. Make > sure to unmap them afterwards. > > Note that the normal approach with sandbox is to use a fixed memory > address in the RAM, to avoid needing to create a map for transient local > variables. > > Signed-off-by: Simon Glass <s...@chromium.org> > --- > > (no changes since v1) > > test/cmd/mbr.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/test/cmd/mbr.c b/test/cmd/mbr.c > index 1a35ba3351c..8a4d61b2928 100644 > --- a/test/cmd/mbr.c > +++ b/test/cmd/mbr.c > @@ -461,6 +461,9 @@ static int mbr_test_run(struct unit_test_state *uts) > "5P EBR+0x%04X: expected %#02X, actual: %#02X\n", > ebr_cmp_start + i, ebr_parts_ref_p5[i], > rbuf[ebr_cmp_start + i]); > } > + unmap_sysmem(mbr_wbuf); > + unmap_sysmem(ebr_wbuf); > + unmap_sysmem(rbuf);
Seems like a Fixes: tag is needed? Thanks /Ilias > > return 0; > } > -- > 2.34.1 >
