Re: [PATCH v8 22/23] test/py: add HTTP (wget) test for the EFI loader

[Jerome Forissier]

On 8/7/24 19:52, Tom Rini wrote:
> On Wed, Aug 07, 2024 at 07:12:06PM +0200, Jerome Forissier wrote:
> 
>> Add a test to test_efi_loader.py similar to the TFTP test but for HTTP
>> with the wget command.
>>
>> Suggested-by: Tom Rini <tr...@konsulko.com>
>> Signed-off-by: Jerome Forissier <jerome.foriss...@linaro.org>
> [snip]
>> +@pytest.mark.buildconfigspec('of_control')
>> +@pytest.mark.buildconfigspec('cmd_bootefi_hello_compile')
>> +def test_efi_helloworld_net_tftp(u_boot_console):
> 
> This should also depend on cmd_tftpboot (existing bug).

Patch added to v9.
 
>> +    """Run the helloworld.efi binary via TFTP.
>> +
>> +    The helloworld.efi file is downloaded from the TFTP server and is 
>> executed
>> +    using the fallback device tree at $fdtcontroladdr.
>> +    """
>> +
>> +    do_test_efi_helloworld_net(u_boot_console, PROTO_TFTP);
>> +
>> +@pytest.mark.buildconfigspec('of_control')
>> +@pytest.mark.buildconfigspec('cmd_bootefi_hello_compile')
>> +def test_efi_helloworld_net_http(u_boot_console):
> 
> Then this needs to depend on cmd_wget as well.

Right. Fixed in v9.

> Kicking my local build
> scripts to add wget and moving on...

Thanks for testing!

-- 
Jerome