Hello Dragan， At 2024-08-12 05:26:36, "Dragan Simic" <[email protected]> wrote: >Hello Andy, > >Please see a few comments below. > >On 2024-08-11 12:02, Andy Yan wrote: >> Add support for Cool Pi GenBook. >> >> Specification: >> - Rockchip RK3588 >> - LPDDR5X 8/32 GB >> - eMMC 64 GB >> - HDMI Type A out x 1 >> - USB 3.0 Host x 1 >> - USB-C 3.0 with DisplayPort AltMode >> - PCIE M.2 E Key for RTL8852BE Wireless connection >> - PCIE M.2 M Key for NVME connection >> - eDP panel with 1920x1080 > >It should be mentioned that it actually uses CM5 SoM. Okay，will do in v2
> >> >> Test by a Armbian boot on USB disk. >> >> Signed-off-by: Andy Yan <[email protected]> >> >> --- >> >> .../dts/rk3588-coolpi-cm5-genbook-u-boot.dtsi | 70 ++++ >> arch/arm/mach-rockchip/rk3588/Kconfig | 7 + >> board/coolpi/genbook/Kconfig | 12 + >> board/coolpi/genbook/MAINTAINERS | 7 + >> board/coolpi/genbook/README | 23 ++ >> configs/coolpi-genbook-rk3588_defconfig | 104 ++++++ >> .../rockchip/rk3588-coolpi-cm5-genbook.dts | 349 ++++++++++++++++++ >> include/configs/genbook-rk3588.h | 28 ++ >> 8 files changed, 600 insertions(+) >> create mode 100644 arch/arm/dts/rk3588-coolpi-cm5-genbook-u-boot.dtsi >> create mode 100644 board/coolpi/genbook/Kconfig >> create mode 100644 board/coolpi/genbook/MAINTAINERS >> create mode 100644 board/coolpi/genbook/README >> create mode 100644 configs/coolpi-genbook-rk3588_defconfig >> create mode 100644 >> dts/upstream/src/arm64/rockchip/rk3588-coolpi-cm5-genbook.dts >> create mode 100644 include/configs/genbook-rk3588.h >> >> diff --git a/arch/arm/dts/rk3588-coolpi-cm5-genbook-u-boot.dtsi >> b/arch/arm/dts/rk3588-coolpi-cm5-genbook-u-boot.dtsi >> new file mode 100644 >> index 00000000000..5835bd4352b >> --- /dev/null >> +++ b/arch/arm/dts/rk3588-coolpi-cm5-genbook-u-boot.dtsi >> @@ -0,0 +1,70 @@ >> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) >> + >> +#include "rk3588-u-boot.dtsi" >> + >> +&fspim2_pins { >> + bootph-pre-ram; >> + bootph-some-ram; >> +}; >> + >> +&sdhci { >> + cap-mmc-highspeed; >> + mmc-hs200-1_8v; >> +}; >> + >> +&sfc { >> + pinctrl-names = "default"; >> + pinctrl-0 = <&fspim2_pins>; >> + status = "okay"; >> + >> + flash@0 { >> + compatible = "jedec,spi-nor"; >> + reg = <0>; >> + bootph-pre-ram; >> + bootph-some-ram; >> + spi-max-frequency = <24000000>; >> + spi-rx-bus-width = <4>; >> + spi-tx-bus-width = <1>; >> + }; >> +}; >> + >> +&u2phy0 { >> + status = "okay"; >> +}; >> + >> +&u2phy0_otg { >> + status = "okay"; >> +}; >> + >> +&usbdp_phy0 { >> + status = "okay"; >> +}; >> + >> +/* For Keypad */ >> +&usb_host0_ehci { >> + status = "disabled"; >> +}; >> + >> +&usb_host0_ohci { >> + status = "disabled"; >> +}; >> + >> +&usb_host0_xhci { >> + dr_mode = "peripheral"; >> + maximum-speed = "high-speed"; >> + status = "okay"; >> +}; >> + >> +/* connected to a HUB for camera and BT */ >> +&usb_host1_ehci { >> + status = "disabled"; >> +}; >> + >> +&usb_host1_ohci { >> + status = "disabled"; >> +}; >> + >> +/* USB A out */ >> +&usb_host1_xhci { >> + snps,dis_u3_susphy_quirk; >> +}; >> diff --git a/arch/arm/mach-rockchip/rk3588/Kconfig >> b/arch/arm/mach-rockchip/rk3588/Kconfig >> index e751d64e1a1..dc53d559ed9 100644 >> --- a/arch/arm/mach-rockchip/rk3588/Kconfig >> +++ b/arch/arm/mach-rockchip/rk3588/Kconfig >> @@ -6,6 +6,12 @@ config TARGET_EVB_RK3588 >> help >> RK3588 EVB is a evaluation board for Rockchp RK3588. >> >> +config TARGET_GENBOOK_RK3588 > >It should be better to use "TARGET_GENBOOK_CM5_RK3588" instead, Considering the name of dts is rk3588-coolpi-cm5-genbook.dts , should we use TARGET_CM5_GENBOOK_RK3588 instead of TARGET_GENBOOK_CM5_RK3588 here ? >to leave room for support for any possible future SoMs that might >be made available for the GenBook at some point. >
