On Mon, Aug 26, 2024 at 5:58 PM Fabio Estevam <[email protected]> wrote: > > From: Fabio Estevam <[email protected]> > > '#define CFG_MXC_USB_PORTSC (PORT_PTS_UTMI | PORT_PTS_PTW)' can > be removed from mx5/mx6/mx7/mx8m board config files as it is the > default in drivers/usb/host/ehci-mx5.c and drivers/usb/host/ehci-mx6.c. > > Suggested-by: Tim Harvey <[email protected]> > Signed-off-by: Fabio Estevam <[email protected]> > --- <snip> > #ifdef CONFIG_CMD_NET > diff --git a/include/configs/m53menlo.h b/include/configs/m53menlo.h > index 1491c509820d..a668eb70fc73 100644 > --- a/include/configs/m53menlo.h > +++ b/include/configs/m53menlo.h > @@ -71,7 +71,6 @@ > */ > #ifdef CONFIG_CMD_USB > #define CFG_MXC_USB_PORT 1 > -#define CFG_MXC_USB_PORTSC (PORT_PTS_UTMI | PORT_PTS_PTW) > #endif >
Hi Fabio, Thanks for doing this - we are at a point where the include/configs/<board>.h files are almost empty. It doesn't look like CFG_MXC_USB_PORT (defined in 6 mx51/mx53 includes) is not used anymore so it can be removed as well. With all of these outdated USB defines removed you could also prune out the enclosing '#ifdef CONFIG_CMD_USB' and the '/* USB configs */' comments in the includes but that certainly would be a manual edit of the files. Best Regards, Tim
