On Tue, Aug 27, 2024 at 07:45:32PM -0600, Simon Glass wrote: > When MMC booting fails it is sometimes hard to figure out what went > wrong as there is no error code. It isn't even clear which MMC device > was chosen, since SPL can have its own numbering. > > Add some debugging to help with this. > > Signed-off-by: Simon Glass <[email protected]> [snip] > +#if CONFIG_IS_ENABLED(DM_MMC) > + log_debug("mmc %d: %s\n", mmc_dev, > + CONFIG_IS_ENABLED(DM_MMC) ? (*mmcp)->dev->name : "?"); > +#endif
Please rework to clean this up. I'm not sure we can drop the #if here (as if ->dev->name is invalid in the non-DM_MMC case, compilation will still fail), but it's silly to have a check for CONFIG_IS_ENABLED(DM_MMC) inside #if CONFIG_IS_ENABLED(DM_MMC) -- Tom
signature.asc
Description: PGP signature
