> -----Original Message----- > From: Alexander Dahl <a...@thorsis.com> > Sent: Thursday, 19 September 2024 2:06 pm > To: Maniyam, Dinesh <dinesh.mani...@intel.com> > Cc: u-boot@lists.denx.de; Marek <ma...@denx.de>; Simon > <simon.k.r.goldschm...@gmail.com>; Tom Rini <tr...@konsulko.com>; Dario > Binacchi <dario.binac...@amarulasolutions.com>; Michael Trimarchi > <mich...@amarulasolutions.com>; Johan Jonker <jbx6...@gmail.com>; Michal > Simek <michal.si...@amd.com>; Arseniy Krasnov > <avkras...@salutedevices.com>; Alexander Dahl <a...@thorsis.com>; William > Zhang <william.zh...@broadcom.com>; Igor Prusov > <ivpru...@salutedevices.com>; Chee, Tien Fong <tien.fong.c...@intel.com>; > Hea, Kok Kiang <kok.kiang....@intel.com>; Ng, Boon Khai > <boon.khai...@intel.com>; Yuslaimi, Alif Zakuan > <alif.zakuan.yusla...@intel.com>; Teik Heng <teik.heng.ch...@intel.com>; > Zamri, Muhammad Hazim Izzat <muhammad.hazim.izzat.za...@intel.com>; > Meng, Tingting <tingting.m...@intel.com>; Lim, Jit Loon > <jit.loon....@intel.com>; Tang, Sieu Mun <sieu.mun.t...@intel.com> > Subject: Re: [PATCH 00/19] Add Cadence NAND Driver support > > Hello Dinesh, > > Am Thu, Sep 19, 2024 at 11:54:53AM +0800 schrieb dinesh.mani...@intel.com: > > From: Dinesh Maniyam <dinesh.mani...@intel.com> > > > > This patchset add Cadence NAND driver support for Intel Agilex5 > > devices. > > > > The NAND driver is leveraged from the cadence-nand-controller.c from > > Linux. U-Boot will support read, write and erase NAND with Cadence > > driver. The driver further enhanced in U-Boot to support NAND booting > > from FSBL and support boot to kernel via UBIFS. > > Could you please add to your U-Boot commit messages the exact Linux version > you used for porting? This makes it easier in the future to re-import Linux > bindings, dts, and driver updates to U-Boot. > > Also avoid phrases like "This patch is to" in commit messages, this adds > redundancy for no reason. > > Greets > Alex > > > > > Dinesh Maniyam (19): > > dt: nand: add cadence nand dt-bindings > > arm: dts: agilex5: Enabled cdns-nand dts setting > > include: asm: Add support to read/write 64-bit > > drivers: mtd: nand: Add driver for Cadence Nand > > drivers: mtd: nand: cadence: Add support for read status command > > drivers: mtd: nand: cadence: Add support for readid command > > drivers: mtd: nand: cadence: Add support for NAND_CMD_PARAM > > drivers: mtd: nand: cadence: Support NAND_CMD_RESET > > drivers: mtd: nand: cadence: Support cmd SET_FEATURES & GET_FEATURES > > drivers: mtd: nand: cadence: Flush dma descriptor > > drivers: mtd: nand: cadence: Poll for desc complete status > > drivers: mtd: nand: cadence: Use bounce buffer > > drivers: nand: Enabled Kconfig and Makefile for cdns-nand > > configs: nand2_defconfig: Enable configs for nand boot > > drivers: mtd: nand: base: Add support for Hardware ECC for check bad > > block > > drivers: mtd: nand: spl: Add support for nand SPL load image > > drivers: mtd: nand: Enabled Kconfig and Makefile for Cadence-SPL > > drivers: mtd: nand: Kconfig: Remove SYS_NAND_BLOCK_SIZE dependency > > drivers: mtd: nand: Kconfig: Enabled self-init for cdns-nand SPL > > > > arch/arm/dts/socfpga_agilex5.dtsi | 14 + > > .../arm/dts/socfpga_agilex5_socdk-u-boot.dtsi | 28 + > > arch/arm/include/asm/io.h | 25 + > > configs/socfpga_agilex5_nand2_defconfig | 169 ++ > > .../mtd/cadence,nand.yaml | 98 + > > drivers/mtd/nand/raw/Kconfig | 19 +- > > drivers/mtd/nand/raw/Makefile | 2 + > > drivers/mtd/nand/raw/cadence_nand.c | 2386 +++++++++++++++++ > > drivers/mtd/nand/raw/cadence_spl.c | 96 + > > drivers/mtd/nand/raw/nand_base.c | 71 +- > > include/cadence-nand.h | 528 ++++ > > include/linux/mtd/rawnand.h | 13 + > > 12 files changed, 3424 insertions(+), 25 deletions(-) create mode > > 100644 configs/socfpga_agilex5_nand2_defconfig > > create mode 100644 doc/device-tree-bindings/mtd/cadence,nand.yaml > > create mode 100644 drivers/mtd/nand/raw/cadence_nand.c > > create mode 100644 drivers/mtd/nand/raw/cadence_spl.c > > create mode 100644 include/cadence-nand.h > > > > -- > > 2.26.2 > >
Hi Alexander, The patch I leverage is from the path /drivers/mtd/nand/raw/cadence-nand-controller.c from the stable version 6.11.2 Please expect the next version of this patch, in which I will remove the "this patch is to" commit phrases and minor refactoring of code to match the stable version 6.11.2. Thanks Dinesh
