Hi Manorit, On Mon, 7 Oct 2024 at 22:48, Manorit Chawdhry <[email protected]> wrote: > > Hi Simon, > > On 09:23-20241007, Simon Glass wrote: > > Hi Manorit, > > > > On Fri, 4 Oct 2024 at 00:24, Manorit Chawdhry <[email protected]> wrote: > > > > > > This series adds support for AVS on J721S2. > > > > What is AVS? You should write an abbreviation out in full at least > > once in the series. > > Totally missed this part, let me take that up in the next revision! > > But basically it is Adaptive voltage scaling. This allows us to run > our CPU with the optimal voltage for that particular silicon which would > have been written in efuse during manufacturing itself. This helps in > saving power during runtime [0]
OK thank you. Regards, Simon > > [0]: https://www.ti.com/lit/pdf/spruj28 (Section 5.2.4.1 AVS Support) > > Regards, > Manorit > > > > > > > > > AVS Test for J721S2: > > > https://gist.github.com/manorit2001/b2fd9f6764a863294d4aa0755c83c84f > > > Boot Test results: > > > https://gist.github.com/manorit2001/15e45f6c421aeeb93effde023a537762 > > > > > > Signed-off-by: Manorit Chawdhry <[email protected]> > > > --- > > > Changes in v4: > > > > > > * Udit > > > - Use the compatible for finding the node rather than alias. > > > - Remove debug print > > > - Add ret value in error prints > > > > > > - Link to v3: > > > https://lore.kernel.org/r/[email protected] > > > > > > --- > > > Manorit Chawdhry (7): > > > power: pmic: tps65941: Add DM_PMIC dependency > > > drivers: misc: k3_avs: Check return code while programming AVS > > > arm: dts: k3-j7*-r5: Add MPU clock in clocks property > > > drivers: misc: k3_avs: Extract MPU clk and dev ID from DT > > > arm: mach-k3: j721s2_init: Initialize AVS Class 0 > > > arm: dts: j721s2: Add VTM node in R5 > > > configs: j721s2_evm_r5_defconfig: Add AVS Configs > > > > > > arch/arm/dts/k3-am69-r5-sk.dts | 3 +- > > > arch/arm/dts/k3-j7200-r5-common-proc-board.dts | 3 +- > > > arch/arm/dts/k3-j721e-r5.dtsi | 3 +- > > > arch/arm/dts/k3-j721s2-r5-common-proc-board.dts | 9 ++++++ > > > arch/arm/dts/k3-j721s2-r5.dtsi | 3 +- > > > arch/arm/dts/k3-j784s4-r5-evm.dts | 3 +- > > > arch/arm/mach-k3/j721s2/j721s2_init.c | 10 +++++++ > > > configs/am68_sk_r5_defconfig | 4 +++ > > > configs/j721s2_evm_r5_defconfig | 6 ++++ > > > drivers/misc/k3_avs.c | 40 > > > ++++++++++++++++++++++++- > > > drivers/power/pmic/Kconfig | 1 + > > > 11 files changed, 79 insertions(+), 6 deletions(-) > > > --- > > > base-commit: 3a0b829efc35227b1079a444f00e0729502197ad > > > change-id: 20240130-b4-upstream-j721s2-avs-8c187d3fe26a > > > > > > Best regards, > > > -- > > > Manorit Chawdhry <[email protected]> > > > > > > > Regards, > > Simon
