[PATCH v3 3/6] mtd: spi-nor: Check nor->info before setting macronix_octal_fixups

Mon, 14 Oct 2024 21:09:50 -0700 

From: Takahiro Kuwano <[email protected]>

The macronix_octal_fixups should be set only when mfr and flags match.

Fixes: df3d5f9e41 ("mtd: spi-nor: add support for Macronix Octal flash")
Acked-by: Tudor Ambarus <[email protected]>
Signed-off-by: Takahiro Kuwano <[email protected]>
Cc: JaimeLiao <[email protected]>
---
 drivers/mtd/spi/spi-nor-core.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/mtd/spi/spi-nor-core.c b/drivers/mtd/spi/spi-nor-core.c
index d39d0ee7813..466729cd2a7 100644
--- a/drivers/mtd/spi/spi-nor-core.c
+++ b/drivers/mtd/spi/spi-nor-core.c
@@ -4423,7 +4423,9 @@ void spi_nor_set_fixups(struct spi_nor *nor)
 #endif
 
 #if CONFIG_IS_ENABLED(SPI_FLASH_MACRONIX)
-       nor->fixups = &macronix_octal_fixups;
+       if (JEDEC_MFR(nor->info) == SNOR_MFR_MACRONIX &&
+           nor->info->flags & SPI_NOR_OCTAL_DTR_READ)
+               nor->fixups = &macronix_octal_fixups;
 #endif /* SPI_FLASH_MACRONIX */
 }
 
-- 
2.34.1

Reply via email to