On Fri, 18 Oct 2024 at 04:30, Heinrich Schuchardt
<heinrich.schucha...@canonical.com> wrote:
>
> There are no users of the blk_create_device() function outside the uclass.
> Let's make it static. This will ensure that new block drivers will use
> blk_create_devicef().
>
> Signed-off-by: Heinrich Schuchardt <heinrich.schucha...@canonical.com>
> ---
> drivers/block/blk-uclass.c | 19 ++++++++++++++++---
> include/blk.h | 17 -----------------
> 2 files changed, 16 insertions(+), 20 deletions(-)
>
> diff --git a/drivers/block/blk-uclass.c b/drivers/block/blk-uclass.c
> index 312e038445c..f3ac8db9464 100644
> --- a/drivers/block/blk-uclass.c
> +++ b/drivers/block/blk-uclass.c
> @@ -695,9 +695,22 @@ static int blk_claim_devnum(enum uclass_id uclass_id,
> int devnum)
> return -ENOENT;
> }
>
> -int blk_create_device(struct udevice *parent, const char *drv_name,
> - const char *name, int uclass_id, int devnum, int blksz,
> - lbaint_t lba, struct udevice **devp)
> +/**
> + * blk_create_device() - Create a new block device
> + *
> + * @parent: Parent of the new device
> + * @drv_name: Driver name to use for the block device
> + * @name: Name for the device
> + * @uclass_id: Interface type (enum uclass_id_t)
> + * @devnum: Device number, specific to the interface type, or -1 to
> + * allocate the next available number
> + * @blksz: Block size of the device in bytes (typically 512)
> + * @lba: Total number of blocks of the device
> + * @devp: the new device (which has not been probed)
> + */
> +static int blk_create_device(struct udevice *parent, const char *drv_name,
> + const char *name, int uclass_id, int devnum,
> + int blksz, lbaint_t lba, struct udevice **devp)
> {
> struct blk_desc *desc;
> struct udevice *dev;
> diff --git a/include/blk.h b/include/blk.h
> index 1fc9a5b8471..261c7dd6616 100644
> --- a/include/blk.h
> +++ b/include/blk.h
> @@ -376,23 +376,6 @@ int blk_first_device(int uclass_id, struct udevice
> **devp);
> */
> int blk_next_device(struct udevice **devp);
>
> -/**
> - * blk_create_device() - Create a new block device
> - *
> - * @parent: Parent of the new device
> - * @drv_name: Driver name to use for the block device
> - * @name: Name for the device
> - * @uclass_id: Interface type (enum uclass_id_t)
> - * @devnum: Device number, specific to the interface type, or -1 to
> - * allocate the next available number
> - * @blksz: Block size of the device in bytes (typically 512)
> - * @lba: Total number of blocks of the device
> - * @devp: the new device (which has not been probed)
> - */
> -int blk_create_device(struct udevice *parent, const char *drv_name,
> - const char *name, int uclass_id, int devnum, int blksz,
> - lbaint_t lba, struct udevice **devp);
> -
> /**
> * blk_create_devicef() - Create a new named block device
> *
> --
> 2.45.2
>
Reviewed-by: Ilias Apalodimas <ilias.apalodi...@linaro.org>
