Hi, Stefano, 2011/5/11 Stefano Babic <[email protected]>: > On 05/11/2011 10:03 AM, Jason Liu wrote: >> This patch add initial support for freescale MX53LOCO board. >> Network(FEC),SD/MMC,UART have been supported by this patch >> >> The patch also config CPU:1GHZ,DDR:400MHZ for better peformance >> >> Signed-off-by: Jason Liu <[email protected]> > > Hi Jason, > ... >> u32 get_cpu_rev(void); >> #define is_soc_rev(rev) ((get_cpu_rev() & 0xFF) - rev) >> void sdelay(unsigned long); >> +void pmic_reg_write(u32 reg, u32 value); >> +u32 pmic_reg_read(u32 reg); > > The pmic_ prototypes have nothing to do with the Soc prototype, as they > are specific for a driver. You should move them in the dialog header. >
I think I need create one head file named: include/dlg_pmic.h to include the pmic_reg_write/read declaration and not just put the declaration to da9053.h file, what's your idea? Jason > > Best regards, > Stefano Babic > > -- > ===================================================================== > DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: [email protected] > ===================================================================== > _______________________________________________ > U-Boot mailing list > [email protected] > http://lists.denx.de/mailman/listinfo/u-boot > _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
