Hi Heinrich, On Thu, 14 Nov 2024 at 03:58, Heinrich Schuchardt <[email protected]> wrote: > > On 11/2/24 20:36, Simon Glass wrote: > > This test doesn't belong at the top level. Move it into the lib/ > > directory, since that is where compression is implemented. > > > > Signed-off-by: Simon Glass <[email protected]> > > --- > > > > (no changes since v1) > > > > test/Makefile | 1 - > > test/lib/Makefile | 3 +++ > > test/{ => lib}/compression.c | 0 > > 3 files changed, 3 insertions(+), 1 deletion(-) > > rename test/{ => lib}/compression.c (100%) > > > > diff --git a/test/Makefile b/test/Makefile > > index 5d62b5c3357..ff621344a03 100644 > > --- a/test/Makefile > > +++ b/test/Makefile > > @@ -10,7 +10,6 @@ endif > > obj-$(CONFIG_$(XPL_)CMDLINE) += cmd/ > > obj-$(CONFIG_$(XPL_)CMDLINE) += cmd_ut.o > > obj-$(CONFIG_$(XPL_)CMDLINE) += command_ut.o > > -obj-$(CONFIG_$(XPL_)UT_COMPRESSION) += compression.o > > obj-y += dm/ > > obj-$(CONFIG_FUZZ) += fuzz/ > > ifndef CONFIG_SANDBOX_VPL > > diff --git a/test/lib/Makefile b/test/lib/Makefile > > index a54387a058e..ce22780eed8 100644 > > --- a/test/lib/Makefile > > +++ b/test/lib/Makefile > > @@ -2,6 +2,9 @@ > > # > > # (C) Copyright 2018 > > # Mario Six, Guntermann & Drunck GmbH, [email protected] > > + > > +obj-$(CONFIG_$(XPL_)UT_COMPRESSION) += compression.o > > + > > ifeq ($(CONFIG_XPL_BUILD),) > > obj-y += cmd_ut_lib.o > > obj-y += abuf.o > > diff --git a/test/compression.c b/test/lib/compression.c > > similarity index 100% > > rename from test/compression.c > > rename to test/lib/compression.c > > Can we now use LIB_TEST instead of the COMPRESSION_TEST macro?
Yes, we could. There was some discussion (with Tom) as to whether we should break things up this way. For example I changed bloblist back to being separate, in the later version of this series. I would be quite happy with just having ~one test suite per dir. Regards, Simon
