Hi Francesco, Stefan!
On 18.11.24 16:37, Stefan Roese wrote:
On 18.11.24 13:31, Francesco Dolcini wrote:
On Mon, Nov 18, 2024 at 07:26:55AM +0100, Heiko Schocher wrote:
Driver for a PMIC watchdog timer controlled via Siemens SCU firmware
extensions. Only useful on some Siemens i.MX8-based platforms as
special SCFW is needed which provides the needed SCU API.
Signed-off-by: Andrej Valek <[email protected]>
Signed-off-by: Heiko Schocher <[email protected]>
...
diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
index 0e45f0a0922..f317d0922cb 100644
--- a/drivers/watchdog/Kconfig
+++ b/drivers/watchdog/Kconfig
@@ -428,6 +428,13 @@ config WDT_ARM_SMC
Select this to enable Arm SMC watchdog timer. This watchdog will manage
a watchdog based on ARM SMCCC communication.
+config WDT_SCU_PMIC
Isn't this a too generic name for something the is platform specific?
Or this is not Siemens specific? One or the other, I would say.
This is also my only concern right now. If this driver is specific for
a Siemens SCU firmware, then IMHO the Kconfig option and the driver
filename should reflect this.
Yep, I change this in next version.
Thanks!
bye,
Heiko
--
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: [email protected]
