Hi Huan Zhou Thanks for taking this one step further.
On Fri, 2024-11-29 at 13:37 +0800, Huan Zhou wrote: > Banana Pi F3 board is a industrial grade RISC-V development board, it > design with SpacemiT K1 8 core RISC-V chip, CPU integrates 2.0 TOPs AI > computing power. 4G DDR and 16G eMMC onboard. There are also variants with different sizes of DDR and/or eMMC available. I do e.g. have one with 16 GB DDR and 128 GB eMMC. > 2x GbE Ethernet port, 4x USB > 3.0 and PCIe for M.2 interface, support HDMI and Dual MIPI-CSI Camera. > > This patch introduces fundamental support for the Banana Pi F3 board, > encompassing UART, CPU, and PLIC support. This ensures that U-Boot can > operate in serial console mode. I have only some minor comments on the second patch (see separate email). Plus you could mention that this patch set is against the top of the riscv custodian's next branch. > Changes in v4: > - Change uart compatible in k1.dtsi in v3, cause related driver in not > implemented in u-boot. > - Update doc, show how to validate the patch. > - Update maintainer, remove kongyang cause he lefted. > - Link to v3: > https://lore.kernel.org/r/20241114-pickup-bpif3-v3-0-98a45802a...@gmail.com > > Changes in v3: > - Add base commit > - Clear redifinition warning while building in UART_IIR_ID > - Change underscore to dash in bananapi*f3 > - Update maintainer > - link to v2 > https://lore.kernel.org/u-boot/20240718043329.1500-1-seashell11234...@gmail.com/ > > Changes in v2: > - Change license to GPL-2.0-or-later > - Add memory node for dts > - Add ft_board_setup function for kernel memory init > - Use default prompt > - links to v1 > https://lore.kernel.org/u-boot/20240714150828.736-1-seashell11234...@gmail.com/ > > Signed-off-by: Huan Zhou <pericycle...@gmail.com> > Signed-off-by: Kongyang Liu <seashell11234...@gmail.com> Whole series Tested-by: Marcel Ziswiler <mar...@ziswiler.com> > --- > Kongyang Liu (2): > riscv: spacemit: bananapi_f3: initial support added > doc: spacemit: bananapi_f3: document Banana Pi F3 board > > arch/riscv/Kconfig | 5 + > arch/riscv/cpu/k1/Kconfig | 18 ++ > arch/riscv/cpu/k1/Makefile | 6 + > arch/riscv/cpu/k1/cpu.c | 9 + > arch/riscv/cpu/k1/dram.c | 54 ++++ > arch/riscv/dts/Makefile | 1 + > arch/riscv/dts/k1-bananapi-f3.dts | 25 ++ > arch/riscv/dts/k1.dtsi | 459 > +++++++++++++++++++++++++++++++++ > board/spacemit/bananapi-f3/Kconfig | 25 ++ > board/spacemit/bananapi-f3/MAINTAINERS | 6 + > board/spacemit/bananapi-f3/Makefile | 5 + > board/spacemit/bananapi-f3/board.c | 9 + > configs/bananapi-f3_defconfig | 20 ++ > doc/board/index.rst | 1 + > doc/board/spacemit/bananapi-f3.rst | 86 ++++++ > doc/board/spacemit/index.rst | 8 + > include/configs/bananapi-f3.h | 13 + > 17 files changed, 750 insertions(+) > --- > base-commit: 40c45a57974bdb09fffa31dde65ddf69e5de53eb > change-id: 20241112-pickup-bpif3-245ab208b9a4 > > Best regards, Cheers Marcel
