On Tue, Dec 17, 2024 at 03:03:57PM +0100, Linus Walleij wrote: > On Thu, Dec 5, 2024 at 9:36 PM Heinrich Schuchardt > <[email protected]> wrote: > > > Building qemu_arm64_defconfig with CONFIGS_DM_RTC=n and CONFIGS_RTC_PL031=y > > leads to a build failure. > > > > Adjust the vexpress64 configuration to avoid circular dependency. > > > > Signed-off-by: Heinrich Schuchardt <[email protected]> > > --- > > v2: > > Adjust the vexpress64 configuration to avoid circular dependency. > > > + imply DM_RTC > > imply RTC_PL031 > > - select DM_RTC if RTC_PL031 > > Should it not be: > imply RTC_PL031 if DM_RTC > > (The dependency in the driver will fix it I guess.) > > The way we are using imply in U-Boot is a bit worrisome > but I'm no expert. It may work better in our case because we > never have an option be "m" (module) as in Linux... This > works for sure.
In this case, DM_RTC (and most DT_xxx symbols) are library functions. In this case, RTC_PL031 already correctly depends on DM_RTC. So we imply DM_RTC here so that we can then also imply RTC_PL031. -- Tom
signature.asc
Description: PGP signature
