On 12/24/24 4:34 PM, Abbarapu, Venkatesh wrote:

[...]

@@ -1593,18 +1595,23 @@ static int spi_nor_read(struct mtd_info *mtd, loff_t
from, size_t len,
        }

        while (len) {
-               bank = (u32)from / SZ_16M;
-               if (nor->flags & SNOR_F_HAS_PARALLEL)
-                       bank /= 2;
-
-               rem_bank_len = SZ_16M * (bank + 1);
-               if (nor->flags & SNOR_F_HAS_PARALLEL)
-                       rem_bank_len *= 2;
-               rem_bank_len -= from;
-
+               size_t read_len = len;

size_t read_len should be declared at the beginning of this function.

                offset = from;

+       if (CONFIG_IS_ENABLED(SPI_STACKED_PARALLEL)) {

The indent here needs to be pushed on tab RIGHT -> .

Do you need this functionality in SPL ? If so, you might need a matching Kconfig
SPL_SPI_STACKED_PARALLEL symbol .

This functionality is not needed for SPL.

So SPL does use SPI NOR in non-stacked/parallel mode, and U-Boot does use it in stacked/parallel mode ? Doesn't that pose a problem ?

[...]

FLASH_BAR and stacked parallel configuration doesn’t depend on each other.
Is the use of BAR register and stacked/parallel mode mutually exclusive or can they be used together ?

Reply via email to