Hi Quentin, At 2025-01-15 17:29:10, "Quentin Schulz" <[email protected]> wrote: >Hi Andy, > >On 1/13/25 11:56 AM, Andy Yan wrote: >> The defconfig name should be: coolpi-cm5-genbook-rk3588_defconfig >> >> Signed-off-by: Andy Yan <[email protected]> > >Reviewed-by: Quentin Schulz <[email protected]>
First, thanks for your review. > >> --- >> >> doc/board/coolpi/genbook_cm5_rk3588.rst | 2 +- > >What about renaming every file that are inconsistent in naming? > >board/coolpi/genbook_cm5_rk3588/ to board/coolpi/cm5_genbook_rk3588/ >doc/board/coolpi/genbook_cm5_rk3588.rst to >doc/board/coolpi/cm5_genbook_rk3588.rst >include/configs/genbook-cm5-rk3588.h to include/configs/cm5-genbook-rk3588.h > >If we do this change, we also need to change a few variables in >Kconfig/defconfig. If we do this change, it needs to be done in a >separate patch though! Please check the review records when I first submitted the patch for this board's support[0][1], As for myself, I can accept both naming conventions. However, different reviewer seem to have different nameing rules. [0]https://lore.kernel.org/u-boot/[email protected]/ [1]https://lore.kernel.org/u-boot/[email protected]/ > >What do you think? Anyway, I think this patch should be merged first to avoid misleading others who want to practice on their own. > >Cheers, >Quentin
