On 1/16/25 10:31 AM, Mattijs Korpershoek wrote:
Hi Varadarajan,
Thank you for the patch.
On mer., janv. 15, 2025 at 11:50, Varadarajan Narayanan
<quic_var...@quicinc.com> wrote:
dwc3_core_init loops 'timeout' times to check if the IP block is out
of reset using 'while (timeout--)'. If there is some issue and
the block doesn't come out of reset, the loop will run till
'timeout' becomes zero and the post decrement operator would set
timeout to 0xffffffff. Though the IP block is not out reset, the
subsequent if check 'if !timeout' would fail as timeout is not
equal to zero and the function proceeds with the initialization.
Use poll API instead to resolve this.
Tested-By: Varadarajan Narayanan <quic_var...@quicinc.com>
s/Tested-By/Tested-by
See ./scripts/checkpatch.pl:
λ ~/work/upstream/src/u-boot/ varadarajan/dwc3-timeout ./scripts/checkpatch.pl
--u-boot --git HEAD^..HEAD
WARNING: 'Tested-by:' is the preferred signature form
#16:
Tested-By: Varadarajan Narayanan <quic_var...@quicinc.com>
total: 0 errors, 1 warnings, 0 checks, 33 lines checked
Signed-off-by: Varadarajan Narayanan <quic_var...@quicinc.com>
I think Marek can fix-up that when he applies, but if you send a v3 to
correct this, feel free to add:
TB by author is a bit odd, so I dropped both TBs and kept RBs only.
