On 18/01/2025 06:15, Marek Vasut wrote:
> Multiple drivers copy MDIO name into struct bb_miiphy_bus name, but
> these two name fields have different length, the bb_miiphy_bus one
> is 16 bytes, the source one is 32 bytes. Make sure these two lengths
> are always synchronized, use MDIO_NAME_LEN for both.
> 
> Signed-off-by: Marek Vasut <[email protected]>

I would prefer something like the following so that it's clear which
source struct we're referring to:

    Multiple drivers copy the MDIO instance name from struct mii_phy to
    struct bb_miiphy_bus, but the name field in these two structs have
    different lengths...

With that changed,

Reviewed-by: Paul Barker <[email protected]>

-- 
Paul Barker

Attachment: OpenPGP_0x27F4B3459F002257.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature

Reply via email to