Hi Sam, On Wed, 22 Jan 2025 at 03:27, Sam Day <[email protected]> wrote: > > commit fc37a73e6679 ("fdt: Swap the signature for > board_fdt_blob_setup()") introduced a subtle change to the Snapdragon > implementation, removing the assignment to gd->fdt_blob partway through > the function. > > This breaks qcom_parse_memory() which was also called during > board_fdt_blob_setup(). > > The underlying issue here is that qcom_parse_memory is using the of_ api > to traverse a devicetree, which relies on the fdt_blob in global data. > > Rather than relying on this subtle behaviour, explicitly pass the FDT > that should be consulted for a /memory node. > > Using the OF API is typically preferable because it's easier to read, > but using the lower level fdt_ methods instead here doesn't add too much > complexity, I think. > > Finally, a minor tweak was made to board_fdt_blob_setup to use the > passed fdt blob pointer instead of gd->fdt_blob, which removes the last > of the references to global data in this area. > > Fixes: fc37a73e6679 (fdt: Swap the signature for board_fdt_blob_setup()) > Reviewed-by: Caleb Connolly <[email protected]> > Signed-off-by: Sam Day <[email protected]> > --- > arch/arm/mach-snapdragon/board.c | 15 ++++++++------- > 1 file changed, 8 insertions(+), 7 deletions(-) >
Reviewed-by: Simon Glass <[email protected]> But I'm looking forward to some form of Caleb's patch landing too[1]. Regards, SImon [1] https://patchwork.ozlabs.org/project/uboot/patch/[email protected]/
