On Wed, 29 Jan 2025 09:28:56 +0800 "黄利亚" <[email protected]> wrote:
Hi LiYa, Happy New Year! > That's the first question.Now I see this option in menuconfig, it should not > be available on other models.I used the following command: > export CROSS_COMPILE=arm-none-eabi- ARCH=arm > make stm32h750-art-pi_defconfig > make menuconfig > ARM architecture --->Enable DIPs detection for CHIP > board (NEW) > > So I implemented this patch to fix it. > But I find that the root cause is that this > config is not included in if ARCH_SUNXI. Yes, as I mentioned, you are right, it shouldn't be there, that's a bug when this option was introduced. > This is the second problem.I tried to include it, > but got a compiler error. > > diff --git a/arch/arm/mach-sunxi/Kconfig b/arch/arm/mach-sunxi/Kconfig > index ba1b1541437..b467ab098c0 100644 > --- a/arch/arm/mach-sunxi/Kconfig > +++ b/arch/arm/mach-sunxi/Kconfig > @@ -1133,8 +1133,6 @@ config BLUETOOTH_DT_DEVICE_FIXUP > > source "board/sunxi/Kconfig" > > -endif > - Ah, you just need to move that "source" line above together with the endif, so that it ends up as: ============== config CHIP_DIP_SCAN .... source "board/sunxi/Kconfig" endif ============== That worked for me. If you can confirm this, please send a v2 with that change, and I am happy to take it. Cheers, Andre > config CHIP_DIP_SCAN > bool "Enable DIPs detection for CHIP board" > select SUPPORT_EXTENSION_SCAN > @@ -1143,3 +1141,6 @@ config CHIP_DIP_SCAN > select W1_EEPROM > select W1_EEPROM_DS24XXX > select CMD_EXTENSION > + > + > +endif > > > > The error message for running make menuconfig is as follows: > arch/arm/mach-sunxi/Kconfig:1146: 'endif' in different file than 'if' > arch/arm/mach-sunxi/Kconfig:1: location of the 'if' > arch/arm/Kconfig:2417: 'endmenu' in different file than 'menu' > arch/arm/mach-sunxi/Kconfig:1: location of the 'menu > > > Cheers, > LiYa > > > ------------------ Original ------------------ > From: > "Andre Przywara" > > <[email protected]>; > Date: Tue, Jan 28, 2025 11:55 PM > To: "黄利亚"<[email protected]>; > Cc: "Chris Morgan"<[email protected]>;"Jagan > Teki"<[email protected]>;"Jernej > Skrabec"<[email protected]>;"Maksim > Kiselev"<[email protected]>;"Michael > Walle"<[email protected]>;"Samuel Holland"<[email protected]>;"Simon > Glass"<[email protected]>;"SumitGarg"<[email protected]>;"Tom > Rini"<[email protected]>;"u-boot"<[email protected]>; > Subject: Re: [PATCH] arm: The CHIP DIP SCAN option should not be > displayed in other mach > > > > On Tue, 28 Jan 2025 21:37:37 +0800 > [email protected] wrote: > > Hi, > > > From: Liya Huang <[email protected]> > > > > When I use mach STM32, > > menuconfig sees this option; It bothers me. > > I observed that the root cause was that the > > option was not included in the endif, > > but when I tried to fix it, an error occurred. > > Can you say what the error is, exactly? > Because you are right, it should be before the endif. > I moved that, and compiled it for all Allwinner boards, which worked. > So what is the problem there, exactly? > > Cheers, > Andre > > > I didn't find a solution. Only deponds can be used for hiding. > > > > Signed-off-by: Liya Huang <[email protected]> > > --- > > > > arch/arm/mach-sunxi/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/arm/mach-sunxi/Kconfig b/arch/arm/mach-sunxi/Kconfig > > index ba1b1541437..48dd1e68363 100644 > > --- a/arch/arm/mach-sunxi/Kconfig > > +++ b/arch/arm/mach-sunxi/Kconfig > > @@ -1137,6 +1137,7 @@ endif > > > > config CHIP_DIP_SCAN > > bool "Enable DIPs detection for CHIP board" > > + depends on ARCH_SUNXI > > select SUPPORT_EXTENSION_SCAN > > select W1 > > select W1_GPIO
