On Monday, May 23, 2011 14:38:52 Matthew McClintock wrote: > There are some checkpatch.pl warnings for formatting issues. In this case > I choose to keep the same formatting as was used in the file already:
this is fine i think. otherwise, you'd send another patch to first fix the
formatting and then base this on top of that.
> +void __flush_icache(void)
> +{
> + /* please define arch specific flush_icache */
> + printf("No arch specific flush_icache available!\n");
> +}
> +void flush_icache(void) __attribute__((weak, alias("__flush_icache")));
i dont see much point in having the indirection. just do:
void __weak flush_icache(void)
{
/* please define arch specific flush_icache */
puts("No arch specific flush_icache available!\n");
}
-mike
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
