> -----Original Message-----
> From: Simon Glass <[email protected]>
> Sent: Tuesday, 18 February 2025 9:29 pm
> To: Maniyam, Dinesh <[email protected]>
> Cc: [email protected]; Marek <[email protected]>; Simon Goldschmidt
> <[email protected]>; Tom Rini <[email protected]>; Ilias
> Apalodimas <[email protected]>; Heinrich Schuchardt
> <[email protected]>; Jerome Forissier <[email protected]>; Mattijs
> Korpershoek <[email protected]>; Ibai Erkiaga <ibai.erkiaga-
> [email protected]>; Michal Simek <[email protected]>; Dmitry Rokosov
> <[email protected]>; Jonas Karlman <[email protected]>; Sebastian
> Reichel <[email protected]>; Wang Jie <dave.wang@rock-
> chips.com>; Meng, Tingting <[email protected]>; Chee, Tien Fong
> <[email protected]>; Hea, Kok Kiang <[email protected]>; Ng,
> Boon Khai <[email protected]>; Yuslaimi, Alif Zakuan
> <[email protected]>; Zamri, Muhammad Hazim Izzat
> <[email protected]>; Lim, Jit Loon
> <[email protected]>; Tang, Sieu Mun <[email protected]>
> Subject: Re: [PATCH 09/10] cmd: Add i3c command support.
> 
> Hi Dinesh,
> 
> On Mon, 17 Feb 2025 at 19:58, <[email protected]> wrote:
> >
> > From: Dinesh Maniyam <[email protected]>
> >
> > Add i3c command file to support select, get i3c device target list,
> > read and write operation.
> >
> > Signed-off-by: Dinesh Maniyam <[email protected]>
> > ---
> >  cmd/i3c.c                          | 193 +++++++++++++++++++++++++++++
> >  drivers/i3c/master/dw-i3c-master.c |  35 +++++-
> >  include/dw-i3c.h                   |   2 +
> >  include/i3c.h                      |   4 +
> >  4 files changed, 233 insertions(+), 1 deletion(-)  create mode 100644
> > cmd/i3c.c
> 
> Please can you add doc/usage/cmd in this patch?
> 
> Ideally there should be a simple test of the command too, like test/dm/acpi.c 
> or
> the things in test/cmd/
> 
> Regards,
> Simon

Noted, will add the doc/usage/cmd  and simple test for this new i3c command 
support in v2.

Regards
Dinesh

Reply via email to