On 2/17/25 19:14, Dario Binacchi wrote:
> It is pointless to use the custom compatible "st,led1" when
> stm32746g-eval.dts and stm32f769-disco.dts already contain the
> "gpio-leds" compatible, which is specifically used for GPIO LEDs
> management. In the case of stm32f746-disco.dts, since it lacks the
> "gpio-leds" compatible, it was decided to translate "st,led1" into
> its "gpio-leds" version in stm32f746-disco-u-boot.dtsi.
>
> Signed-off-by: Dario Binacchi <[email protected]>
> ---
>
> arch/arm/dts/stm32746g-eval-u-boot.dtsi | 5 -----
> arch/arm/dts/stm32f746-disco-u-boot.dtsi | 9 ++++++---
> arch/arm/dts/stm32f769-disco-u-boot.dtsi | 5 -----
> board/st/stm32f746-disco/stm32f746-disco.c | 16 ----------------
> 4 files changed, 6 insertions(+), 29 deletions(-)
>
> diff --git a/arch/arm/dts/stm32746g-eval-u-boot.dtsi
> b/arch/arm/dts/stm32746g-eval-u-boot.dtsi
> index f64329287357..32b5c7cea4b8 100644
> --- a/arch/arm/dts/stm32746g-eval-u-boot.dtsi
> +++ b/arch/arm/dts/stm32746g-eval-u-boot.dtsi
> @@ -22,11 +22,6 @@
> mmc0 = &sdio1;
> spi0 = &qspi;
> };
> -
> - led1 {
> - compatible = "st,led1";
> - led-gpio = <&gpiof 10 0>;
> - };
> };
>
> &fmc {
> diff --git a/arch/arm/dts/stm32f746-disco-u-boot.dtsi
> b/arch/arm/dts/stm32f746-disco-u-boot.dtsi
> index e0e2f9e23773..69b50c7a1076 100644
> --- a/arch/arm/dts/stm32f746-disco-u-boot.dtsi
> +++ b/arch/arm/dts/stm32f746-disco-u-boot.dtsi
> @@ -33,9 +33,12 @@
> };
> };
>
> - led1 {
> - compatible = "st,led1";
> - led-gpio = <&gpioi 1 0>;
> + leds {
> + compatible = "gpio-leds";
> + led-usr {
> + gpios = <&gpioi 1 GPIO_ACTIVE_HIGH>;
> + linux,default-trigger = "heartbeat";
> + };
No need to add leds node, as CONFIG_LED_GPIO is not enable in
configs/stm32f746-disco_defconfig
Thanks
Patrice
> };
> };
>
> diff --git a/arch/arm/dts/stm32f769-disco-u-boot.dtsi
> b/arch/arm/dts/stm32f769-disco-u-boot.dtsi
> index a50fba64dcd2..7c99a6e61b68 100644
> --- a/arch/arm/dts/stm32f769-disco-u-boot.dtsi
> +++ b/arch/arm/dts/stm32f769-disco-u-boot.dtsi
> @@ -23,11 +23,6 @@
> spi0 = &qspi;
> };
>
> - led1 {
> - compatible = "st,led1";
> - led-gpio = <&gpioj 5 0>;
> - };
> -
> panel: panel {
> compatible = "orisetech,otm8009a";
> reset-gpios = <&gpioj 15 1>;
> diff --git a/board/st/stm32f746-disco/stm32f746-disco.c
> b/board/st/stm32f746-disco/stm32f746-disco.c
> index 65a39d965c72..72f479cea66f 100644
> --- a/board/st/stm32f746-disco/stm32f746-disco.c
> +++ b/board/st/stm32f746-disco/stm32f746-disco.c
> @@ -78,22 +78,6 @@ u32 spl_boot_device(void)
>
> int board_late_init(void)
> {
> - struct gpio_desc gpio = {};
> - int node;
> -
> - node = fdt_node_offset_by_compatible(gd->fdt_blob, 0, "st,led1");
> - if (node < 0)
> - return -1;
> -
> - gpio_request_by_name_nodev(offset_to_ofnode(node), "led-gpio", 0, &gpio,
> - GPIOD_IS_OUT);
> -
> - if (dm_gpio_is_valid(&gpio)) {
> - dm_gpio_set_value(&gpio, 0);
> - mdelay(10);
> - dm_gpio_set_value(&gpio, 1);
> - }
> -
> return 0;
> }
>
