On Sun, Mar 09, 2025 at 03:06:43PM +0100, Christian Marangi wrote: > Add initial support for Airoha AN7581 SoC. This adds the initial Kconfig > and Makefile entry for the SoC, an initial RFB DTS and initial config > for it. Also add the initial code for cpu and RAM initialization. > > Signed-off-by: Christian Marangi <[email protected]> [snip] > diff --git a/arch/arm/mach-airoha/Kconfig b/arch/arm/mach-airoha/Kconfig > new file mode 100644 > index 00000000000..0470a01034f > --- /dev/null > +++ b/arch/arm/mach-airoha/Kconfig > @@ -0,0 +1,44 @@ > +if ARCH_AIROHA > + > +config SYS_SOC > + default "airoha" > + > +config SYS_VENDOR > + default "airoha" > + > +choice > + prompt "Airoha board select" > + > +config TARGET_AN7581 > + bool "Airoha AN7581 SoC" > + select ARM64 > + help > + The Airoha EN7581 is a ARM-based SoC with a quad-core Cortex-A7 > + including NEON and GPU, Mali-450 graphics, several DDR3 options, > + crypto engine, built-in Wi-Fi / Bluetooth combo chip, JPEG decoder, > + video interfaces supporting HDMI and MIPI, and video codec support. > + Peripherals include Gigabit Ethernet, switch, USB3.0 and OTG, PCIe, > + I2S, PCM, S/PDIF, UART, SPI, I2C, IR TX/RX, and PWM. > + > +endchoice > + > +config SYS_BOARD > + string "Board name" > + default "an7581" if TARGET_AN7581 > + default "" > + help > + This option contains information about board name. > + Based on this option board/<CONFIG_SYS_VENDOR>/<CONFIG_SYS_BOARD> will > + be used. > + > +config SYS_CONFIG_NAME > + string "Board configuration name" > + default "an7581" if TARGET_AN7581 > + default "" > + help > + This option contains information about board configuration name. > + Based on this option include/configs/<CONFIG_SYS_CONFIG_NAME>.h header > + will be used for board configuration.
We shouldn't prompt for SYS_BOARD / SYS_CONFIG_NAME and instead just provide the values here. [snip] > diff --git a/board/airoha/an7581/MAINTAINERS b/board/airoha/an7581/MAINTAINERS > new file mode 100644 > index 00000000000..480b89a73aa > --- /dev/null > +++ b/board/airoha/an7581/MAINTAINERS > @@ -0,0 +1,6 @@ > +AN7581 > +M: Christian Marangi <[email protected]> > +S: Maintained > +F: board/airoha/an7581 > +F: include/configs/an7581.h > +F: configs/an7581_rfb_defconfig You should probably use the "N:" syntax here and say "N: an7581" to catch all the files later on too. Perhaps also "N: airoha" to catch the drivers you add later. > diff --git a/configs/an7581_evb_defconfig b/configs/an7581_evb_defconfig > new file mode 100644 > index 00000000000..b37511c026e > --- /dev/null > +++ b/configs/an7581_evb_defconfig This doesn't appear to be the output of "make savedefconfig" so please re-sync it with that. > diff --git a/include/configs/an7581.h b/include/configs/an7581.h > new file mode 100644 > index 00000000000..901d99b3456 > --- /dev/null > +++ b/include/configs/an7581.h > @@ -0,0 +1,19 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* > + * Configuration for Airoha AN7581 > + */ > + > +#ifndef __AN7581_H > +#define __AN7581_H > + > +#include <linux/sizes.h> > + > +#define CONFIG_SYS_UBOOT_BASE CONFIG_TEXT_BASE > + > +#define CFG_SYS_INIT_RAM_ADDR CONFIG_TEXT_BASE > +#define CFG_SYS_INIT_RAM_SIZE SZ_2M > + > +/* DRAM */ > +#define CONFIG_SYS_SDRAM_BASE 0x80000000 You cannot set CONFIG symbols in this file anymore. -- Tom
signature.asc
Description: PGP signature
