On Tue, Mar 18, 2025 at 09:38:59PM +0530, Harsha Vardhan V M wrote: > > > On 18/03/25 19:39, Tom Rini wrote: > > On Tue, Mar 18, 2025 at 04:20:43PM +0530, Harsha Vardhan V M wrote: > > > > > Remove custom string functions and replace them with normal string > > > functions. Remove the custom strtou32 and replace it with > > > simple_strtoul. > > > > > > Signed-off-by: Harsha Vardhan V M <[email protected]> > > [snip] > > > @@ -54,14 +43,18 @@ static int do_fuse(struct cmd_tbl *cmdtp, int flag, > > > int argc, > > > argc -= 2 + confirmed; > > > argv += 2 + confirmed; > > > - if (argc < 2 || strtou32(argv[0], 0, &bank) || > > > - strtou32(argv[1], 0, &word)) > > > + if (argc < 2) > > > return CMD_RET_USAGE; > > > + bank = (u32)simple_strtoul(argv[0], NULL, 0); > > > > Do we really need these casts? > > > > Not really, Just added them to make it explicit. > I can remove the casts if that's preferred.
Yes, please drop the casts throughout and post the next iteration as non-RFC, thanks! -- Tom
signature.asc
Description: PGP signature
