Hi Kever, On 2025-01-24 14:00, Jonas Karlman wrote: > Hi Kever, > > On 2025-01-24 12:25, Kever Yang wrote: >> Hi Jonas, >> >> On 2025/1/24 06:48, Jonas Karlman wrote: >>> From: Joseph Chen <[email protected]> >>> >>> Import rk3528-pinctrl.dtsi from vendor U-Boot and Linux tag >>> linux-6.1-stan-rkr5 with the hdmi-pins-idle node removed due to missing >>> label reference to pcfg_output_low_pull_down. >>> >>> Signed-off-by: Joseph Chen <[email protected]> >>> Signed-off-by: Jonas Karlman <[email protected]> >>> --- >>> arch/arm/dts/rk3528-pinctrl.dtsi | 1397 ++++++++++++++++++++++++++++++ >> >> This should go to mainline kernel first with rk3528.dtsi for this new >> chip support, >> >> I don't understand why this need to send separately. > > The rk3528.dtsi in upstream Linux v6.13-dts is very basic and only > contain cpu nodes and uart nodes. There is a pending series to add basic > CRU support. > > This series is going a little bit ahead of upstream Linux and add bare > minimum to get working boot from eMMC and SD-card. Something that > require working CRU and pinctrl. > > Guess we can always wait on full support of CRU, pinctrl, sdhci and > sdmmc to land in upstream Linux before we add support for the SoC in > U-Boot.
More features including rk3528-pinctrl.dtsi have now landed in torvalds Linux tree. I will send a v2 of this series once a v6.15-rc1-dts tag is pushed to devicetree-rebasing. Until then I keep a work-in-progress branch at [1]. [1] https://source.denx.de/u-boot/contributors/kwiboo/u-boot/-/commits/rk3528 Regards, Jonas > > Regards, > Jonas > >> >> >> Thanks, >> - Kever >>> 1 file changed, 1397 insertions(+) >>> create mode 100644 arch/arm/dts/rk3528-pinctrl.dtsi >>> >>> diff --git a/arch/arm/dts/rk3528-pinctrl.dtsi >>> b/arch/arm/dts/rk3528-pinctrl.dtsi >>> new file mode 100644 >>> index 000000000000..ea051362fb26 >>> --- /dev/null >>> +++ b/arch/arm/dts/rk3528-pinctrl.dtsi >>> @@ -0,0 +1,1397 @@ >>> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) >>> +/* >>> + * Copyright (c) 2022 Rockchip Electronics Co., Ltd. >>> + */ >>> + >>> +#include <dt-bindings/pinctrl/rockchip.h> >>> +#include "rockchip-pinconf.dtsi" >>> + >>> +/* >>> + * This file is auto generated by pin2dts tool, please keep these code >>> + * by adding changes at end of this file. >>> + */ >>> +&pinctrl { > > [snip] > >>> +}; >
