On 5/12/25 19:21, Marek Vasut wrote:
> Add SPL specific DT additions to DH STM32MP13xx DHCOR DHSBC . These
> include I2C3 configuration which is required to access the PMIC,
> PMIC regulator and QSPI NOR bootph-all properties to allow SPL to
> configure PMIC buck regulators and load from QSPI NOR respectively,
> etzpc bus switch to simple-bus to prevent interference from TFABOOT
> specific configuration, and RCC configuration to define clock tree
> configuration used by this platform.
>
> Signed-off-by: Marek Vasut <marek.va...@mailbox.org>
Hi Marek
This patch is causing DT compilation errors when using stm32mp15_defconfig and
stm32mp15_trusted_defconfig, see below:
./tools/buildman/buildman -j16 -e -d -V -v -E -m stm32mp
Generating board list...Processing #include to produce configs/lager_defconfig
Processing #include to produce configs/imx8mp_dhcom_pdk3_defconfig
Processing #include to produce configs/j784s4_evm_a72_defconfig
Processing #include to produce configs/stout_defconfig
[...]
Processing #include to produce configs/am62ax_evm_a53_defconfig
Processing #include to produce configs/r8a779g0_whitehawk_defconfig
Processing #include to produce configs/silk_defconfig
Processing #include to produce configs/r8a77995_draak_defconfig
Building current source for 19 boards (8 threads, 16 jobs per thread)
arm: + stm32mp15
+dts/upstream/src/arm/st/stm32mp135f-dhcor-dhsbc.dtb: ERROR
(phandle_references): /soc/rcc@50000000: Reference to non-existent node or
label "clk_hse"
+
+dts/upstream/src/arm/st/stm32mp135f-dhcor-dhsbc.dtb: ERROR
(phandle_references): /soc/rcc@50000000: Reference to non-existent node or
label "clk_hsi"
+dts/upstream/src/arm/st/stm32mp135f-dhcor-dhsbc.dtb: ERROR
(phandle_references): /soc/rcc@50000000: Reference to non-existent node or
label "clk_csi"
+dts/upstream/src/arm/st/stm32mp135f-dhcor-dhsbc.dtb: ERROR
(phandle_references): /soc/rcc@50000000: Reference to non-existent node or
label "clk_lse"
+dts/upstream/src/arm/st/stm32mp135f-dhcor-dhsbc.dtb: ERROR
(phandle_references): /soc/rcc@50000000: Reference to non-existent node or
label "clk_lsi"
+ERROR: Input tree has errors, aborting (use -f to force output)
+make[3]: *** [scripts/Makefile.lib:396:
dts/upstream/src/arm/st/stm32mp135f-dhcor-dhsbc.dtb] Error 1
+make[2]: *** [dts/Makefile:60: arch-dtbs] Error 2
+make[1]: *** [Makefile:1168: dts/dt.dtb] Error 2
+make: *** [Makefile:177: sub-make] Error 2
arm: w+ stm32mp13_dhcor
w+dts/upstream/src/arm/st/stm32mp135f-dhcor-dhsbc.dtb: Warning (reg_format):
/soc/rcc@50000000/st,pll@1:reg: property has invalid length (4 bytes)
(#address-cells == 2, #size-cells == 1)
w+dts/upstream/src/arm/st/stm32mp135f-dhcor-dhsbc.dtb: Warning (reg_format):
/soc/rcc@50000000/st,pll@2:reg: property has invalid length (4 bytes)
(#address-cells == 2, #size-cells == 1)
w+dts/upstream/src/arm/st/stm32mp135f-dhcor-dhsbc.dtb: Warning (reg_format):
/soc/rcc@50000000/st,pll@3:reg: property has invalid length (4 bytes)
(#address-cells == 2, #size-cells == 1)
w+dts/upstream/src/arm/st/stm32mp135f-dhcor-dhsbc.dtb: Warning
(avoid_default_addr_size): /soc/rcc@50000000/st,pll@1: Relying on default
#address-cells value
w+dts/upstream/src/arm/st/stm32mp135f-dhcor-dhsbc.dtb: Warning
(avoid_default_addr_size): /soc/rcc@50000000/st,pll@1: Relying on default
#size-cells value
w+dts/upstream/src/arm/st/stm32mp135f-dhcor-dhsbc.dtb: Warning
(avoid_default_addr_size): /soc/rcc@50000000/st,pll@2: Relying on default
#address-cells value
w+dts/upstream/src/arm/st/stm32mp135f-dhcor-dhsbc.dtb: Warning
(avoid_default_addr_size): /soc/rcc@50000000/st,pll@2: Relying on default
#size-cells value
w+dts/upstream/src/arm/st/stm32mp135f-dhcor-dhsbc.dtb: Warning
(avoid_default_addr_size): /soc/rcc@50000000/st,pll@3: Relying on default
#address-cells value
w+dts/upstream/src/arm/st/stm32mp135f-dhcor-dhsbc.dtb: Warning
(avoid_default_addr_size): /soc/rcc@50000000/st,pll@3: Relying on default
#size-cells value
arm: + stm32mp15_trusted
+dts/upstream/src/arm/st/stm32mp135f-dhcor-dhsbc.dtb: ERROR
(phandle_references): /soc/rcc@50000000: Reference to non-existent node or
label "clk_hse"
+
+dts/upstream/src/arm/st/stm32mp135f-dhcor-dhsbc.dtb: ERROR
(phandle_references): /soc/rcc@50000000: Reference to non-existent node or
label "clk_hsi"
+dts/upstream/src/arm/st/stm32mp135f-dhcor-dhsbc.dtb: ERROR
(phandle_references): /soc/rcc@50000000: Reference to non-existent node or
label "clk_csi"
+dts/upstream/src/arm/st/stm32mp135f-dhcor-dhsbc.dtb: ERROR
(phandle_references): /soc/rcc@50000000: Reference to non-existent node or
label "clk_lse"
+dts/upstream/src/arm/st/stm32mp135f-dhcor-dhsbc.dtb: ERROR
(phandle_references): /soc/rcc@50000000: Reference to non-existent node or
label "clk_lsi"
+ERROR: Input tree has errors, aborting (use -f to force output)
+make[3]: *** [scripts/Makefile.lib:396:
dts/upstream/src/arm/st/stm32mp135f-dhcor-dhsbc.dtb] Error 1
+make[2]: *** [dts/Makefile:60: arch-dtbs] Error 2
+make[1]: *** [Makefile:1168: dts/dt.dtb] Error 2
+make: *** [Makefile:177: sub-make] Error 2
arm: w+ stm32mp15_basic
w+dts/upstream/src/arm/st/stm32mp135f-dhcor-dhsbc.dtb: Warning (reg_format):
/soc/rcc@50000000/st,pll@1:reg: property has invalid length (4 bytes)
(#address-cells == 2, #size-cells == 1)
w+dts/upstream/src/arm/st/stm32mp135f-dhcor-dhsbc.dtb: Warning (reg_format):
/soc/rcc@50000000/st,pll@2:reg: property has invalid length (4 bytes)
(#address-cells == 2, #size-cells == 1)
w+dts/upstream/src/arm/st/stm32mp135f-dhcor-dhsbc.dtb: Warning (reg_format):
/soc/rcc@50000000/st,pll@3:reg: property has invalid length (4 bytes)
(#address-cells == 2, #size-cells == 1)
w+dts/upstream/src/arm/st/stm32mp135f-dhcor-dhsbc.dtb: Warning
(avoid_default_addr_size): /soc/rcc@50000000/st,pll@1: Relying on default
#address-cells value
w+dts/upstream/src/arm/st/stm32mp135f-dhcor-dhsbc.dtb: Warning
(avoid_default_addr_size): /soc/rcc@50000000/st,pll@1: Relying on default
#size-cells value
w+dts/upstream/src/arm/st/stm32mp135f-dhcor-dhsbc.dtb: Warning
(avoid_default_addr_size): /soc/rcc@50000000/st,pll@2: Relying on default
#address-cells value
w+dts/upstream/src/arm/st/stm32mp135f-dhcor-dhsbc.dtb: Warning
(avoid_default_addr_size): /soc/rcc@50000000/st,pll@2: Relying on default
#size-cells value
w+dts/upstream/src/arm/st/stm32mp135f-dhcor-dhsbc.dtb: Warning
(avoid_default_addr_size): /soc/rcc@50000000/st,pll@3: Relying on default
#address-cells value
w+dts/upstream/src/arm/st/stm32mp135f-dhcor-dhsbc.dtb: Warning
(avoid_default_addr_size): /soc/rcc@50000000/st,pll@3: Relying on default
#size-cells value
15 2 2 /19 stm32mp15_basic
Completed: 19 total built, 19 newly), duration 0:07:48, rate 0.04
Thanks
Patrice
> ---
> Cc: Cheick Traore <cheick.tra...@foss.st.com>
> Cc: Fabrice Gasnier <fabrice.gasn...@foss.st.com>
> Cc: Gatien Chevallier <gatien.chevall...@foss.st.com>
> Cc: Lionel Debieve <lionel.debi...@foss.st.com>
> Cc: Pascal Zimmermann <pzimmerm...@dh-electronics.com>
> Cc: Patrice Chotard <patrice.chot...@foss.st.com>
> Cc: Patrick Delaunay <patrick.delau...@foss.st.com>
> Cc: Simon Glass <s...@chromium.org>
> Cc: Sughosh Ganu <sughosh.g...@linaro.org>
> Cc: Tom Rini <tr...@konsulko.com>
> Cc: u-b...@dh-electronics.com
> Cc: u-boot@lists.denx.de
> Cc: uboot-st...@st-md-mailman.stormreply.com
> ---
> arch/arm/dts/stm32mp13xx-dhcor-u-boot.dtsi | 155 ++++++++++++++++++++-
> 1 file changed, 154 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/dts/stm32mp13xx-dhcor-u-boot.dtsi
> b/arch/arm/dts/stm32mp13xx-dhcor-u-boot.dtsi
> index 6117da10bbf..b5952637442 100644
> --- a/arch/arm/dts/stm32mp13xx-dhcor-u-boot.dtsi
> +++ b/arch/arm/dts/stm32mp13xx-dhcor-u-boot.dtsi
> @@ -3,6 +3,7 @@
> * Copyright (C) 2024 Marek Vasut <ma...@denx.de>
> */
>
> +#include <dt-bindings/clock/stm32mp13-clksrc.h>
> #include "stm32mp13-u-boot.dtsi"
> #include "stm32mp13-ddr3-dhsom-1x2Gb-1066-binG.dtsi"
>
> @@ -19,8 +20,12 @@
> };
> };
>
> +&etzpc {
> + compatible = "simple-bus";
> +};
> +
> &flash0 {
> - bootph-pre-ram;
> + bootph-all;
>
> partitions {
> compatible = "fixed-partitions";
> @@ -49,6 +54,134 @@
> };
> };
>
> +&i2c3 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&i2c3_pins_a>;
> +};
> +
> +&qspi {
> + bootph-all;
> +};
> +
> +&qspi_clk_pins_a {
> + bootph-all;
> + pins {
> + bootph-all;
> + };
> +};
> +
> +&qspi_bk1_pins_a {
> + bootph-all;
> + pins {
> + bootph-all;
> + };
> +};
> +
> +&qspi_cs1_pins_a {
> + bootph-all;
> + pins {
> + bootph-all;
> + };
> +};
> +
> +&pinctrl {
> + bootph-all;
> + i2c3_pins_a: i2c3-0 {
> + bootph-all;
> + pins {
> + bootph-all;
> + pinmux = <STM32_PINMUX('B', 8, AF5)>, /* I2C3_SCL */
> + <STM32_PINMUX('H', 14, AF4)>; /* I2C3_SDA */
> + bias-disable;
> + drive-open-drain;
> + slew-rate = <0>;
> + };
> + };
> +};
> +
> +&rcc {
> + clocks = <&clk_hse>, <&clk_hsi>, <&clk_csi>, <&clk_lse>, <&clk_lsi>;
> +
> + st,clksrc = <
> + CLK_MPU_PLL1P
> + CLK_AXI_PLL2P
> + CLK_MLAHBS_PLL3
> + CLK_PLL12_HSE
> + CLK_PLL3_HSE
> + CLK_PLL4_HSE
> + CLK_CKPER_HSE
> + CLK_RTC_LSE
> + CLK_MCO1_LSI
> + CLK_MCO2_HSI
> + >;
> +
> + st,clkdiv = <
> + 0 /*AXI*/
> + 0 /*MLHAB*/
> + 1 /*APB1*/
> + 1 /*APB2*/
> + 1 /*APB3*/
> + 1 /*APB4*/
> + 2 /*APB5*/
> + 1 /*APB6*/
> + 0 /*RTC*/
> + >;
> +
> + st,pkcs = <
> + CLK_I2C12_HSI
> + CLK_I2C3_HSI
> + CLK_QSPI_PLL3R
> + CLK_SAES_AXI
> + CLK_SDMMC1_PLL3R
> + CLK_SDMMC2_PLL3R
> + CLK_STGEN_HSE
> + CLK_UART2_HSI
> + CLK_UART4_HSI
> + CLK_USBO_USBPHY
> + CLK_USBPHY_HSE
> + >;
> +
> + /*
> + * cfg = < DIVM1 DIVN P Q R PQR(p,q,r) >;
> + * frac = < f >;
> + *
> + * PRQ(p,q,r) ... for p,q,r: 0-output disabled / 1-output enabled
> + * DIVN ... actually multiplier, but RCC_PLL1CFGR1 calls the field DIVN
> + * m ... for PLL1,2: m=2 ; for PLL3,4: m=1
> + * XTAL = 24 MHz
> + *
> + * VCO = ( XTAL / (DIVM1 + 1) ) * m * ( DIVN + 1 + ( f / 8192 ) )
> + * P = VCO / (P + 1)
> + * Q = VCO / (Q + 1)
> + * R = VCO / (R + 1)
> + */
> +
> + /* VCO = 1066.0 MHz => P = 266 (AXI), Q = 266, R = 533 (DDR) */
> + pll2: st,pll@1 {
> + compatible = "st,stm32mp1-pll";
> + reg = <1>;
> + cfg = < 2 65 1 1 0 PQR(1,1,1) >;
> + frac = < 0x1400 >;
> + bootph-all;
> + };
> +
> + /* VCO = 600 MHz => P = 200, Q = 150, R = 200 */
> + pll3: st,pll@2 {
> + compatible = "st,stm32mp1-pll";
> + reg = <2>;
> + cfg = < 2 74 2 3 2 PQR(1,1,1) >;
> + bootph-all;
> + };
> +
> + /* VCO = 750.0 MHz => P = 125, Q = 83, R = 75 */
> + pll4: st,pll@3 {
> + compatible = "st,stm32mp1-pll";
> + reg = <3>;
> + cfg = < 3 124 5 8 9 PQR(1,1,1) >;
> + bootph-all;
> + };
> +};
> +
> &sdmmc1 {
> status = "disabled";
> };
> @@ -56,3 +189,23 @@
> &usbotg_hs {
> u-boot,force-b-session-valid;
> };
> +
> +&vddcpu {
> + bootph-all;
> +};
> +
> +&vdd_ddr {
> + bootph-all;
> +};
> +
> +&vdd {
> + bootph-all;
> +};
> +
> +&vddcore {
> + bootph-all;
> +};
> +
> +&vref_ddr {
> + bootph-all;
> +};
