Re: [PATCH 6/6] net: lwip: wget: use loadaddr env var for default address

[Tim Harvey]

On Fri, May 30, 2025 at 1:03 AM Jerome Forissier
<jerome.foriss...@linaro.org> wrote:
>
>
>
> On 5/29/25 23:49, Tim Harvey wrote:
> > The loadAddress is optional and defaults to image_load_address
> > which should be initialized to the 'loadaddr' env variable like the
> > legacy stack (CONFIG_NET) does.
> >
> > Signed-off-by: Tim Harvey <thar...@gateworks.com>
> > ---
> >  net/lwip/wget.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/net/lwip/wget.c b/net/lwip/wget.c
> > index 76401991bde6..ff8dbdc08d9b 100644
> > --- a/net/lwip/wget.c
> > +++ b/net/lwip/wget.c
> > @@ -579,7 +579,7 @@ int do_wget(struct cmd_tbl *cmdtp, int flag, int argc, 
> > char * const argv[])
> >                       return CMD_RET_USAGE;
> >               url = argv[2];
> >       } else {
> > -             dst_addr = image_load_addr;
> > +             dst_addr = env_get_ulong("loadaddr", 16, image_load_addr);
> >               url = argv[1];
> >       }
> >
>
> image_load_addr is initialized in initr_env() (common/board_r.c) so this
> should not be necessary.
>

Hi Jerome,

You are correct - not sure how I missed this. I'll drop it from v2.

Thanks,

Tim