On Wed, Jun 11, 2025 at 10:59:31AM +0200, Quentin Schulz wrote:
> From: Heiko Stuebner <heiko.stueb...@cherry.de>
> 
> Using snps,reset-* properties for handling the phy-reset is deprecated
> and instead a real phy node should be defined that then contains the
> reset-gpios handling.
> 
> To facilitate this, add the core mdio node under the px30's gmac, similar
> to how the other Rockchip socs already do this.
> 
> Signed-off-by: Heiko Stuebner <heiko.stueb...@cherry.de>
> Reviewed-by: Quentin Schulz <quentin.sch...@cherry.de>
> Link: https://lore.kernel.org/r/20250514150745.2437804-2-he...@sntech.de
> Signed-off-by: Heiko Stuebner <he...@sntech.de>
> 
> [ upstream commit: ede4837a504ca7e5811217060aa8300b8d0cf7f2 ]
> 
> (cherry picked from commit cb54a264ecdb9e95b1529e4542e157cb9acded30)
> ---
>  dts/upstream/src/arm64/rockchip/px30.dtsi | 6 ++++++
>  1 file changed, 6 insertions(+)

Nicely done!

Reviewed-by: Sumit Garg <sumit.g...@oss.qualcomm.com>

-Sumit

> 
> diff --git a/dts/upstream/src/arm64/rockchip/px30.dtsi 
> b/dts/upstream/src/arm64/rockchip/px30.dtsi
> index 
> 9137dd76e72cedb0cfbf1995032e5852cab80f96..feabdadfa440f96c0134a0bb05e64a0c7b5adf2e
>  100644
> --- a/dts/upstream/src/arm64/rockchip/px30.dtsi
> +++ b/dts/upstream/src/arm64/rockchip/px30.dtsi
> @@ -985,6 +985,12 @@
>               resets = <&cru SRST_GMAC_A>;
>               reset-names = "stmmaceth";
>               status = "disabled";
> +
> +             mdio: mdio {
> +                     compatible = "snps,dwmac-mdio";
> +                     #address-cells = <1>;
> +                     #size-cells = <0>;
> +             };
>       };
>  
>       sdmmc: mmc@ff370000 {
> 
> -- 
> 2.49.0
> 

Reply via email to