On Wed, Jun 18, 2025 at 09:51:32AM +0200, Heinrich Schuchardt wrote: > On 6/17/25 12:03, Jerome Forissier wrote: > > Prepare to split the dns command from cmd/net-lwip.c by moving the > > implementation from net/lwip/dns.c to cmd/lwip. > > > > Signed-off-by: Jerome Forissier <[email protected]> > > --- > > > > Changes in v3: > > - Move this patch before "lwip: split cmd/net-lwip.c into one file per > > command". > > > > Changes in v2: > > - New patch > > > > MAINTAINERS | 1 + > > cmd/Makefile | 2 +- > > cmd/lwip/Makefile | 1 + > > {net => cmd}/lwip/dns.c | 0 > > net/lwip/Makefile | 1 - > > 5 files changed, 3 insertions(+), 2 deletions(-) > > create mode 100644 cmd/lwip/Makefile > > rename {net => cmd}/lwip/dns.c (100%) > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > index d62dd35a385..e8f644fc75b 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -1409,6 +1409,7 @@ F: net/ > > NETWORK (LWIP) > > M: Jerome Forissier <[email protected]> > > S: Maintained > > +F: cmd/lwip/ > > F: cmd/net-lwip.c > > F: configs/qemu_arm64_lwip_defconfig > > F: drivers/net/sandbox-lwip.c > > diff --git a/cmd/Makefile b/cmd/Makefile > > index 80cf70b7fe8..102422470c2 100644 > > --- a/cmd/Makefile > > +++ b/cmd/Makefile > > @@ -133,7 +133,7 @@ obj-$(CONFIG_CMD_NAND) += nand.o > > ifdef CONFIG_NET > > obj-$(CONFIG_CMD_NET) += net.o net-common.o > > else ifdef CONFIG_NET_LWIP > > -obj-$(CONFIG_CMD_NET) += net-lwip.o net-common.o > > +obj-$(CONFIG_CMD_NET) += net-lwip.o net-common.o lwip/ > > Why should any command implemented in /cmd/lwip/ depend on CONFIG_CMD_NET? > Directory lwip/ should always be traversed if CONFIG_NET_LWIP=y. > > We should get rid of CONFIG_CMD_NET once all commands are well separated.
I think a further cleanup would be to get rid of CONFIG_CMD_NET as it's not an lwIP thing but something that implementation inherited. -- Tom
signature.asc
Description: PGP signature
