On 6/18/25 18:16, Tom Rini wrote:
On Wed, Jun 18, 2025 at 05:44:29PM +0200, Pieter Van Trappen wrote:
On 18/06/2025 15:57, Tom Rini wrote:
On Wed, Jun 18, 2025 at 09:15:54AM +0200, Michal Simek wrote:
On 6/17/25 11:23, vtpie...@gmail.com wrote:
From: Pieter Van Trappen <pieter.van.trap...@cern.ch>
- debug("fpga: incorrect parameters passed\n");
+ puts("fpga: incorrect parameters passed\n");
I think all of these should be moved to log_err that you should be able to
control verbosity.
Tom: I think this is where you want to go right?
Sounds right, thanks.
Right I will amend accordingly in a v2.
I'm trying to compile now that it's more than some tweaks and I notice many
(fixable) errors in the drivers/fpga files such as missing time.h includes,
spotted by gcc 14.2 (x86_64). I'm on the next branch.
Is this due to my gcc being too recent or is something else going on? I
don't mind patching these in case that's welcomed; let me know.
Just further changes on the next branch which your changes are exposing
I guess, separate patches for them would be much appreciated, thanks!
Thanks but that's not the case; I switched to the latest `next` HEAD
which is your commit ce2a7fcb and I get the same error, see below (one
of many). Maybe due to my config in which I enabled all FPGA-related
configs? Is is there a `allyesconfig` pipeline somewhere? Sorry I'm new
to u-boot development and I don't think patchwork is running pipelines.
I'm further investigating, I'm probably doing something wrong although
the gcc errors are correct AFAIK.
drivers/fpga/spartan2.c: In function ‘spartan2_sp_load’:
drivers/fpga/spartan2.c:145:22: error: implicit declaration of function
‘get_timer’ [-Wimplicit-function-declaration]
145 | ts = get_timer (0); /* get current
time */
| ^~~~~~~~~
