From: Tom Rini <tr...@konsulko.com> Sent: Friday, July 11, 2025 7:41 PM > On Fri, Jul 11, 2025 at 05:37:55PM +0000, Christoph Niedermaier wrote: >> From: Tom Rini <tr...@konsulko.com> >> Sent: Thursday, July 10, 2025 3:58 AM >>> Subject: Re: [PATCH V4 0/3] cmd: env: select: Add output for available >>> environment targets >>> >>> On Mon, Jun 30, 2025 at 05:12:29PM +0200, Christoph Niedermaier wrote: >>> >>>> Add the "-l" parameter to the "env select" command to print the available >>>> environment targets, convert all argument parsing in the file nvedit.c to >>>> getopt() and check that with unit tests. >>>> >>>> The first patch converts the parsing of arguments to getopt() for all env >>>> commands. The second one adds unit tests for checking the env command. >>>> These were used to check the env commands before and after the conversion. >>>> The third patch adds the actual new parameter "-l" for the "env select" >>>> command. >>>> >>>> Christoph Niedermaier (3): >>>> cmd: nvedit: Convert the parsing of arguments to getopt() >>>> test: cmd: nvedit: Add basic unit tests >>>> cmd: env: select: Add output for available environment targets >>> >>> Can you please make a v5 that's run through CI? I saw that am64x_evm_a53 >>> fails to build now and I'm seeing the tests fail too: >>> https://source.denx.de/u-boot/u-boot/-/jobs/1196652 >> >> Sorry, I will have a look at it and make a new version. >> Are my patches also the cause of the build issue with am64x_evm_a53? > > Yes, something in the series was leading to at least that platform and > likely many others (I saw that in my local board testing, CI failed the > pipeline before getting to the world stage so I don't know all of the > ones that failed).
OK, then I will also have a look at it. Thanks for the clarification. Regards Christoph
