Smatch reported a possible buffer overflow in exfat_set_label but it turns out that this code is unused so just guard the function with '#ifndef __UBOOT__' as well as exfat_get_label that is also unused and the helper static find_label.
Signed-off-by: Andrew Goodbody <andrew.goodb...@linaro.org> --- Changes in v2: - Instead of removing the code just guard it with #ifndef __UBOOT__ to make future resyncs easier from upstream - Link to v1: https://lore.kernel.org/r/20250717-exfat_label-v1-1-e15f28fd6...@linaro.org --- fs/exfat/exfat.h | 2 ++ fs/exfat/node.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/fs/exfat/exfat.h b/fs/exfat/exfat.h index ca6f22b9d58..bd2965c3942 100644 --- a/fs/exfat/exfat.h +++ b/fs/exfat/exfat.h @@ -237,8 +237,10 @@ int exfat_rename(struct exfat* ef, const char* old_path, const char* new_path); void exfat_utimes(struct exfat_node* node, const struct timespec tv[2]); void exfat_update_atime(struct exfat_node* node); void exfat_update_mtime(struct exfat_node* node); +#ifndef __UBOOT__ const char* exfat_get_label(struct exfat* ef); int exfat_set_label(struct exfat* ef, const char* label); +#endif /* __UBOOT__ */ int exfat_soil_super_block(const struct exfat* ef); int exfat_mount(struct exfat* ef, const char* spec, const char* options); diff --git a/fs/exfat/node.c b/fs/exfat/node.c index 88b1357189c..b7406fbf3ed 100644 --- a/fs/exfat/node.c +++ b/fs/exfat/node.c @@ -1188,6 +1188,7 @@ void exfat_update_mtime(struct exfat_node* node) node->is_dirty = true; } +#ifndef __UBOOT__ const char* exfat_get_label(struct exfat* ef) { return ef->label; @@ -1241,3 +1242,4 @@ int exfat_set_label(struct exfat* ef, const char* label) strcpy(ef->label, label); return 0; } +#endif /* __UBOOT__ */ --- base-commit: 3b4604a40b9fd61b87e9d059fc56f04d36f1a380 change-id: 20250717-exfat_label-bf4af04ea293 Best regards, -- Andrew Goodbody <andrew.goodb...@linaro.org>
