Hi Ben, On 18/08/2025 10:30, Ben Hoelker wrote: > The MAX31331 was not correctly updating the seconds when > setting the time and would return the seconds previously set. > > Like the MAX31343, a delay needs to be added after setting the > time. Wait one second after writing so that the date command shows the > correct time. > > Reviewed-by: Chris Packham <chris.pack...@alliedtelesis.co.nz> > Reviewed-by: Bruce Adams <bruce.ad...@alliedtelesis.co.nz> When sending changes upstream the r-by should come from a responder on the list and will be collected by the maintainer applying the patch. You can include it on v2 of a patch (if it has been offered). > Signed-off-by: Ben Hoelker <ben.hoel...@alliedtelesis.co.nz> The above aside
Reviewed-by: Chris Packham <chris.pack...@alliedtelesis.co.nz> > --- > > drivers/rtc/max313xx.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/rtc/max313xx.c b/drivers/rtc/max313xx.c > index 2cb3f245041..f0d38b10c97 100644 > --- a/drivers/rtc/max313xx.c > +++ b/drivers/rtc/max313xx.c > @@ -308,6 +308,7 @@ static int max313xx_set_time(struct udevice *dev, const > struct rtc_time *t) > return ret; > > break; > + case ID_MAX31331: > case ID_MAX31343: > /* Time is not updated for 1 second after writing */ > /* Sleep here so the date command shows the new time */
