Am 19.08.25 um 12:59 schrieb Frieder Schrempf:
> Am 19.08.25 um 12:47 schrieb Mikhail Kshevetskiy:
>>
>> On 19.08.2025 13:42, Frieder Schrempf wrote:
>>> Am 19.08.25 um 12:34 schrieb Mikhail Kshevetskiy:
>>>> On 19.08.2025 10:26, Frieder Schrempf wrote:
>>>>> Am 18.08.25 um 12:06 schrieb Mikhail Kshevetskiy:
>>>>>> From: Gabor Juhos <j4g...@gmail.com>
>>>>>>
>>>>>> Since commit 3d1f08b032dc ("mtd: spinand: Use the external ECC engine
>>>>>> logic") the spinand_write_page() function ignores the errors returned
>>>>>> by spinand_wait(). Change the code to propagate those up to the stack
>>>>>> as it was done before the offending change.
>>>>>>
>>>>>> This is a port of linux commit
>>>>>> 091d9e35b85b ("mtd: spinand: propagate spinand_wait() errors from
>>>>>> spinand_write_page()")
>>>>>>
>>>>>> Signed-off-by: Gabor Juhos <j4g...@gmail.com>
>>>>>> Signed-off-by: Miquel Raynal <miquel.ray...@bootlin.com>
>>>>>> Signed-off-by: Mikhail Kshevetskiy <mikhail.kshevets...@iopsys.eu> #
>>>>>> U-Boot port
>>>>> This seems to be a fix for a change that was introduced in patch 10 of
>>>>> this series. We should avoid introducing regressions and fixing them in
>>>>> a later patch to preserve bisectability.
>>>> Hm, this a bit contradict with removing fixes for continuous mode. In
>>>> linux, continuous mode makes some flashes (mostly macronix) almost
>>>> unusable on some platforms.
>>> Sorry, I don't understand how this is related to the continuous mode
>>> fixes. I'm just asking to squash patch 19 of this series into patch 10
>>> so the changes of patch 19 are included in patch 10 in order to make
>>> this a single consistent change.
>> you write: We should avoid introducing regressions and fixing them in a
>> later patch to preserve bisectability.
>> Continuous mode introduce regressions (see:
>> https://lkml.org/lkml/2025/8/14/349). My patches fixes this regressions,
>
> Thanks, now I got it. By syncing with the current mainline Linux, we
> also introduce the same regressions that are currently existing in
> Linux, yes.
>
> But that's a different topic than introducing a regression in the
> patchset and fixing it later in the same patchset.
>
> The first problem should IMHO be solved like this:
>
> 1. Fix regresssions in Linux
> 2. Port fixes to U-Boot
>
> If we want to avoid introducing the regressions from Linux, we should
> delay the merging of this patchset until the Kernel is fixed.
I just asked Miquel about the fixes on the kernel side. He thinks they
are good with his review commits for v1 addressed. But he didn't review
the v2 so far.
So if you don't want to wait, you can also add the patches back here
now. Or just wait a bit and then do another sync.
